From: Christian Brauner <christian.brauner@ubuntu.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kars de Jong <jongk@linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] m68k: Wire up clone3() syscall
Date: Tue, 26 Nov 2019 15:41:22 +0100 [thread overview]
Message-ID: <20191126144121.kzkujr27ga36gqnf@wittgenstein> (raw)
In-Reply-To: <CAMuHMdVv9FU+kTf7RDd=AFKL12tJxzmGbX4jZZ8Av3VCZUzwhA@mail.gmail.com>
On Mon, Nov 25, 2019 at 10:12:25AM +0100, Geert Uytterhoeven wrote:
> Hi Kars,
>
> On Sun, Nov 24, 2019 at 8:52 PM Kars de Jong <jongk@linux-m68k.org> wrote:
> > Wire up the clone3() syscall for m68k. The special entry point is done in
> > assembler as was done for clone() as well. This is needed because all
> > registers need to be saved. The C wrapper then calls the generic
> > sys_clone3() with the correct arguments.
> >
> > Tested on A1200 using the simple test program from:
> >
> > https://lore.kernel.org/lkml/20190716130631.tohj4ub54md25dys@brauner.io/
Please note that we now have a growing test-suite for the clone3()
syscall under
tools/testing/selftests/clone3/*
You can test on a suitable kernel with
make TARGETS=clone3 kselftest
> >
> > Cc: linux-m68k@vger.kernel.org
> > Signed-off-by: Kars de Jong <jongk@linux-m68k.org>
>
> Thanks a lot!
> Works fine on ARAnyM, too.
>
> Looks good to me, but I'll wait a bit before applying, so the syscall experts
> can chime in, if needed.
Otherwise this looks good to me.
Thanks for moving this forward. One day we'll be able to remove
ARCH_WANT_SYS_CLONE3 completely. :)
Christian
next prev parent reply other threads:[~2019-11-26 14:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 19:52 [PATCH] m68k: Wire up clone3() syscall Kars de Jong
2019-11-25 9:12 ` Geert Uytterhoeven
2019-11-26 14:41 ` Christian Brauner [this message]
2019-11-26 15:29 ` Kars de Jong
2019-12-15 16:48 ` Geert Uytterhoeven
2019-12-15 17:01 ` John Paul Adrian Glaubitz
2019-12-15 20:06 ` Geert Uytterhoeven
2019-12-16 10:31 ` Christian Brauner
2019-12-18 9:57 ` Kars de Jong
2020-01-12 16:06 ` Geert Uytterhoeven
2020-01-13 9:10 ` Geert Uytterhoeven
2020-01-13 9:18 ` Christian Brauner
2020-01-13 9:34 ` Geert Uytterhoeven
2020-01-13 10:17 ` Christian Brauner
2020-01-13 10:31 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126144121.kzkujr27ga36gqnf@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=geert@linux-m68k.org \
--cc=jongk@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).