Linux-m68k Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] net: amd: a2065: Use print_hex_dump_debug() helper
@ 2020-01-12 16:33 Geert Uytterhoeven
  2020-01-13  0:22 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-01-12 16:33 UTC (permalink / raw)
  To: David S . Miller; +Cc: netdev, linux-m68k, Geert Uytterhoeven

Use the print_hex_dump_debug() helper, instead of open-coding the same
operations.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/ethernet/amd/a2065.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/amd/a2065.c b/drivers/net/ethernet/amd/a2065.c
index 1b025a33b4642f8b..d4823f2969f45b04 100644
--- a/drivers/net/ethernet/amd/a2065.c
+++ b/drivers/net/ethernet/amd/a2065.c
@@ -547,11 +547,10 @@ static netdev_tx_t lance_start_xmit(struct sk_buff *skb,
 	if (!lance_tx_buffs_avail(lp))
 		goto out_free;
 
-#ifdef DEBUG
 	/* dump the packet */
-	print_hex_dump(KERN_DEBUG, "skb->data: ", DUMP_PREFIX_NONE,
-		       16, 1, skb->data, 64, true);
-#endif
+	print_hex_dump_debug("skb->data: ", DUMP_PREFIX_NONE, 16, 1, skb->data,
+			     64, true);
+
 	entry = lp->tx_new & lp->tx_ring_mod_mask;
 	ib->btx_ring[entry].length = (-skblen) | 0xf000;
 	ib->btx_ring[entry].misc = 0;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: amd: a2065: Use print_hex_dump_debug() helper
  2020-01-12 16:33 [PATCH] net: amd: a2065: Use print_hex_dump_debug() helper Geert Uytterhoeven
@ 2020-01-13  0:22 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-01-13  0:22 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: David S . Miller, netdev, linux-m68k

On Sun, 12 Jan 2020 17:33:54 +0100, Geert Uytterhoeven wrote:
> Use the print_hex_dump_debug() helper, instead of open-coding the same
> operations.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied to net-next, thank you!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-12 16:33 [PATCH] net: amd: a2065: Use print_hex_dump_debug() helper Geert Uytterhoeven
2020-01-13  0:22 ` Jakub Kicinski

Linux-m68k Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-m68k/0 linux-m68k/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-m68k linux-m68k/ https://lore.kernel.org/linux-m68k \
		linux-m68k@vger.kernel.org linux-m68k@lists.linux-m68k.org
	public-inbox-index linux-m68k

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-m68k


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git