From: Peter Zijlstra <peterz@infradead.org>
To: Will Deacon <will@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] m68k,mm: Extend table allocator for multiple sizes
Date: Wed, 29 Jan 2020 13:43:52 +0100 [thread overview]
Message-ID: <20200129124352.GP14879@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200129121752.GB31582@willie-the-truck>
On Wed, Jan 29, 2020 at 12:17:53PM +0000, Will Deacon wrote:
> On Wed, Jan 29, 2020 at 11:39:45AM +0100, Peter Zijlstra wrote:
> > +extern void *get_pointer_table(int type);
>
> Could be prettier/obfuscated with an enum type?
Definitely, but then we get to bike-shed on names :-)
enum m68k_table_type {
TABLE_BIG = 0,
TABLE_SMALL,
};
Is not exactly _that_ much better, and while TABLE_PTE works,
TABLE_PGD_PMD is a bit crap.
> > --- a/arch/m68k/mm/memory.c
> > +++ b/arch/m68k/mm/memory.c
> > -pmd_t *get_pointer_table (void)
> > +void *get_pointer_table (int type)
> > {
> > - ptable_desc *dp = ptable_list.next;
> > - unsigned char mask = PD_MARKBITS (dp);
> > - unsigned char tmp;
> > - unsigned int off;
> > + ptable_desc *dp = ptable_list[type].next;
> > + unsigned int mask, tmp, off;
>
> nit, but if you do:
>
> unsigned int mask = list_empty(&ptable_list[type]) ? 0 : PD_MARKBITS(dp);
>
> then you can leave the existing mask logic as-is.
Indeed!
next prev parent reply other threads:[~2020-01-29 12:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 10:39 [PATCH 0/5] Rewrite Motorola MMU page-table layout Peter Zijlstra
2020-01-29 10:39 ` [PATCH 1/5] m68k,mm: Restructure motorola mmu " Peter Zijlstra
2020-01-29 10:39 ` [PATCH 2/5] m68k,mm: Improve kernel_page_table() Peter Zijlstra
2020-01-29 10:39 ` [PATCH 3/5] m68k,mm: Use table allocator for pgtables Peter Zijlstra
2020-01-29 12:11 ` Will Deacon
2020-01-29 12:24 ` Peter Zijlstra
2020-01-29 10:39 ` [PATCH 4/5] m68k,mm: Extend table allocator for multiple sizes Peter Zijlstra
2020-01-29 12:17 ` Will Deacon
2020-01-29 12:43 ` Peter Zijlstra [this message]
2020-01-29 13:15 ` Will Deacon
2020-01-29 10:39 ` [PATCH 5/5] m68k,mm: Fully initialize the page-table allocator Peter Zijlstra
2020-01-29 10:49 ` [PATCH 0/5] Rewrite Motorola MMU page-table layout John Paul Adrian Glaubitz
2020-01-29 11:54 ` Peter Zijlstra
2020-01-29 12:05 ` John Paul Adrian Glaubitz
2020-01-29 12:30 ` Peter Zijlstra
2020-01-29 18:52 ` Michael Schmitz
2020-01-29 19:31 ` Peter Zijlstra
2020-01-30 7:31 ` Michael Schmitz
2020-01-30 8:16 ` Peter Zijlstra
2020-01-30 19:12 ` Michael Schmitz
2020-01-31 6:31 ` Greg Ungerer
2020-01-31 9:38 ` Will Deacon
2020-01-31 10:22 ` Peter Zijlstra
2020-01-31 11:14 ` Peter Zijlstra
2020-01-31 11:18 ` Will Deacon
2020-01-31 11:31 ` Peter Zijlstra
2020-01-31 11:43 ` Will Deacon
2020-01-31 13:04 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129124352.GP14879@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).