Linux-m68k Archive on lore.kernel.org
 help / color / Atom feed
From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: Greg Ungerer <gerg@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Julia Lawall <Julia.Lawall@lip6.fr>
Subject: Re: [PATCH 06/18] m68k: Replace setup_irq() by request_irq()
Date: Fri, 14 Feb 2020 18:37:10 +0530
Message-ID: <20200214130710.GA5675@afzalpc> (raw)
In-Reply-To: <bfb9c0bb-0c16-5516-d788-bbd2ca86fc58@linux-m68k.org>

Hi Greg,

On Thu, Feb 13, 2020 at 05:11:17PM +1000, Greg Ungerer wrote:
> On 12/2/20 6:03 pm, afzal mohammed wrote:

> > diff --git a/arch/m68k/68000/timers.c b/arch/m68k/68000/timers.c
> > index 71ddb4c98726..7a55d664592e 100644
> > --- a/arch/m68k/68000/timers.c
> > +++ b/arch/m68k/68000/timers.c
> > @@ -68,12 +68,6 @@ static irqreturn_t hw_tick(int irq, void *dummy)
> >   /***************************************************************************/
> > -static struct irqaction m68328_timer_irq = {
> > -	.name	 = "timer",
> > -	.flags	 = IRQF_TIMER,
> > -	.handler = hw_tick,
> > -};
> > -
> >   /***************************************************************************/

> Remove this comment line as well. Nothing left to separate
> between those comment lines with the struct initialization removed.

i will remove above as well as the similar ones.

Because  you mentioned, i checked cocci o/p (change above was provided
as is by running cocci). Cocci by default removes the comment line you
mentioned. Initially that was the way cocci was run, but then it was
observed that in another file in addition to removing associated
comments, it was swallowing other unrelated comments that were living
together. Also sometimes associated comments had to be retained, just
that it had to be relocated near added code (that is not applicable in
this case). So i ran cocci w/ "--keep-comments" option & decided to
manually handle comment related, in this file i failed noticing the
unneeded comment line during self review.

> I tested this out on ColdFire hardware I have, worked fine.
> All defconfigs still compiled too.

Thanks for testing

Regards
afzal

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12  8:01 [PATCH 00/18] genirq: Remove setup_irq() afzal mohammed
2020-02-12  8:03 ` [PATCH 06/18] m68k: Replace setup_irq() by request_irq() afzal mohammed
2020-02-12 22:25   ` Finn Thain
2020-02-13  2:03     ` afzal mohammed
2020-02-13  7:11   ` Greg Ungerer
2020-02-14 13:07     ` afzal mohammed [this message]
2020-02-27 10:31 ` [PATCH 00/18] genirq: Remove setup_irq() Thomas Gleixner
2020-02-27 11:07   ` afzal mohammed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214130710.GA5675@afzalpc \
    --to=afzal.mohd.ma@gmail.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-m68k Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-m68k/0 linux-m68k/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-m68k linux-m68k/ https://lore.kernel.org/linux-m68k \
		linux-m68k@vger.kernel.org linux-m68k@lists.linux-m68k.org
	public-inbox-index linux-m68k

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-m68k


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git