From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Christoph Hellwig <hch@lst.de>,
linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com
Subject: [PATCH v5 00/27] ata: optimize core code size on PATA only setups
Date: Thu, 26 Mar 2020 16:57:55 +0100 [thread overview]
Message-ID: <20200326155822.19400-1-b.zolnierkie@samsung.com> (raw)
In-Reply-To: CGME20200326155838eucas1p2a1c1f5c08832410d1e2b5a5ea8226151@eucas1p2.samsung.com
Hi,
There have been reports in the past of libata core code size
being a problem in migration from deprecated IDE subsystem on
legacy PATA only systems, i.e.:
https://lore.kernel.org/linux-ide/db2838b7-4862-785b-3a1d-3bf09811340a@gmail.com/
This patchset re-organizes libata core code to exclude SATA
specific code from being built for PATA only setups.
The end result is up to 24% (by 23949 bytes, from 101769 bytes to
77820 bytes) smaller libata core code size (as measured for m68k
arch using modified atari_defconfig) on affected setups.
I've tested this patchset using pata_falcon driver under ARAnyM
emulator.
patches #1-11 are general fixes/cleanups done in the process of
making the patchset (there should be no inter-dependencies between
them except patch #10 which depends on patch #9)
patch #12 separates PATA timings code to libata-pata-timings.c file
patches #13-15 let compiler optimize out SATA specific code on
non-SATA hosts by adding !IS_ENABLED(CONFIG_SATA_HOST) instances
patches #16-22 separate SATA only code from libata-core.c file to
libata-sata.c one
patches #23-24 separate SATA only code from libata-scsi.c file to
libata-sata.c one
patches #25-26 separate SATA only code from libata-eh.c file to
libata-sata.c one
patch #27 makes "libata.force" kernel parameter optional
Changes since v4
(https://lore.kernel.org/linux-ide/20200317144333.2904-1-b.zolnierkie@samsung.com/):
- rebased on top of next-20200326
- added Reviewed-by tags from Christoph
Changes since v3
(https://lore.kernel.org/linux-ide/20200227182226.19188-1-b.zolnierkie@samsung.com/):
- rebased on top of next-20200317
- fixed sdev_attrs initializer entry defined twice issue found by
kbuild-test-robot/sparse in "ata: expose ncq_enable_prio sysfs
attribute only on NCQ capable hosts" patch
Changes since v2
(https://lore.kernel.org/linux-ide/20200207142734.8431-1-b.zolnierkie@samsung.com/):
- rebased on top of next-20200227
- added "ata: optimize ata_scsi_rbuf[] size" patch
Changes since v1
(https://lore.kernel.org/linux-ide/20200128133343.29905-1-b.zolnierkie@samsung.com/):
- added Acked-by: tag from Tejun to "ata: remove stale maintainership
information from core code" patch
- added Reviewed-by: tag from Martin to "ata: make SATA_PMP option
selectable only if any SATA host driver is enabled" patch
- added Reviewed-by: tag from Christoph to following patches:
- "ata: simplify ata_scsiop_inq_89()"
- "ata: use COMMAND_LINE_SIZE for ata_force_param_buf[] size"
- "ata: optimize struct ata_force_param size"
- "ata: move EXPORT_SYMBOL_GPL()s close to exported code"
- "ata: remove EXPORT_SYMBOL_GPL()s not used by modules"
- converted "ata: add CONFIG_SATA_HOST=n version of ata_ncq_enabled()"
patch to use IS_ENABLED()
- added "ata: let compiler optimize out ata_dev_config_ncq() on
non-SATA hosts" and "ata: let compiler optimize out ata_eh_set_lpm()
on non-SATA hosts" patches
- moved "ata: move sata_scr_*() to libata-core-sata.c" patch just
after "ata: start separating SATA specific code from libata-core.c"
one
- dropped no longer needed patches (code savings <= 8 bytes):
- "ata: move ata_do_link_spd_horkage() to libata-core-sata.c"
- "ata: move ata_dev_config_ncq*() to libata-core-sata.c"
- "ata: move sata_print_link_status() to libata-core-sata.c"
- "ata: move sata_down_spd_limit() to libata-core-sata.c"
- "ata: move sata_link_init_spd() to libata-core-sata.c"
- "ata: move ata_eh_set_lpm() to libata-core-sata.c"
- removed superfluos ifdefs
- dropped file names in top of file headers
- merged libata-scsi-sata.c and libata-eh-sata.c into libata-sata.c
- emphasised in patch descriptions that atari_defconfig used for
measurements has been modified (original one is still using
deprecated IDE subsystem)
- added "ata: make "libata.force" kernel parameter optional" patch
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Bartlomiej Zolnierkiewicz (27):
ata: remove stale maintainership information from core code
ata: expose ncq_enable_prio sysfs attribute only on NCQ capable hosts
ata: make SATA_PMP option selectable only if any SATA host driver is
enabled
sata_promise: use ata_cable_sata()
ata: simplify ata_scsiop_inq_89()
ata: use COMMAND_LINE_SIZE for ata_force_param_buf[] size
ata: optimize struct ata_force_param size
ata: optimize ata_scsi_rbuf[] size
ata: move EXPORT_SYMBOL_GPL()s close to exported code
ata: remove EXPORT_SYMBOL_GPL()s not used by modules
ata: fix CodingStyle issues in PATA timings code
ata: separate PATA timings code from libata-core.c
ata: add CONFIG_SATA_HOST=n version of ata_ncq_enabled()
ata: let compiler optimize out ata_dev_config_ncq() on non-SATA hosts
ata: let compiler optimize out ata_eh_set_lpm() on non-SATA hosts
ata: start separating SATA specific code from libata-core.c
ata: move sata_scr_*() to libata-sata.c
ata: move *sata_set_spd*() to libata-sata.c
ata: move sata_link_{debounce,resume}() to libata-sata.c
ata: move sata_link_hardreset() to libata-sata.c
ata: move ata_qc_complete_multiple() to libata-sata.c
ata: move sata_deb_timing_*() to libata-sata.c
ata: start separating SATA specific code from libata-scsi.c
ata: move ata_sas_*() to libata-sata.c
ata: start separating SATA specific code from libata-eh.c
ata: move ata_eh_analyze_ncq_error() & co. to libata-sata.c
ata: make "libata.force" kernel parameter optional
drivers/ata/Kconfig | 77 ++
drivers/ata/Makefile | 2 +
drivers/ata/libata-core.c | 1126 ++--------------------
drivers/ata/libata-eh.c | 224 +----
drivers/ata/libata-pata-timings.c | 192 ++++
drivers/ata/libata-sata.c | 1483 +++++++++++++++++++++++++++++
drivers/ata/libata-scsi.c | 544 +----------
drivers/ata/libata-sff.c | 4 -
drivers/ata/libata.h | 25 +-
drivers/ata/sata_promise.c | 8 +-
drivers/scsi/Kconfig | 1 +
drivers/scsi/libsas/Kconfig | 1 +
include/linux/libata.h | 172 ++--
13 files changed, 2015 insertions(+), 1844 deletions(-)
create mode 100644 drivers/ata/libata-pata-timings.c
create mode 100644 drivers/ata/libata-sata.c
--
2.24.1
next parent reply other threads:[~2020-03-26 15:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200326155838eucas1p2a1c1f5c08832410d1e2b5a5ea8226151@eucas1p2.samsung.com>
2020-03-26 15:57 ` Bartlomiej Zolnierkiewicz [this message]
[not found] ` <CGME20200326155838eucas1p1931e5db55f9efd231696c210c0690733@eucas1p1.samsung.com>
2020-03-26 15:57 ` [PATCH v5 01/27] ata: remove stale maintainership information from core code Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155839eucas1p2c9e354eb1f81d47c2c00d1c6c42f28a5@eucas1p2.samsung.com>
2020-03-26 15:57 ` [PATCH v5 02/27] ata: expose ncq_enable_prio sysfs attribute only on NCQ capable hosts Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155839eucas1p226e80fe61b5df9c08ec23c7d93c843db@eucas1p2.samsung.com>
2020-03-26 15:57 ` [PATCH v5 03/27] ata: make SATA_PMP option selectable only if any SATA host driver is enabled Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155839eucas1p1d5c84c9070fd1a1282b590172be640b1@eucas1p1.samsung.com>
2020-03-26 15:57 ` [PATCH v5 04/27] sata_promise: use ata_cable_sata() Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155840eucas1p1fd8d2a9a30f2f97dbf4a78258191c624@eucas1p1.samsung.com>
2020-03-26 15:58 ` [PATCH v5 05/27] ata: simplify ata_scsiop_inq_89() Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155840eucas1p2861601dc1c971a2baade72b03baee9f0@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 06/27] ata: use COMMAND_LINE_SIZE for ata_force_param_buf[] size Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155841eucas1p1b9f0b5feb3d00618fc08d962abc709a9@eucas1p1.samsung.com>
2020-03-26 15:58 ` [PATCH v5 07/27] ata: optimize struct ata_force_param size Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155841eucas1p29ed1b37ca4364f205c6404ed978aa007@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 08/27] ata: optimize ata_scsi_rbuf[] size Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155842eucas1p16ec1dd1303741c202766ce6f1264df5d@eucas1p1.samsung.com>
2020-03-26 15:58 ` [PATCH v5 09/27] ata: move EXPORT_SYMBOL_GPL()s close to exported code Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155842eucas1p23d6b95d066eaf1a86e04935641015af6@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 10/27] ata: remove EXPORT_SYMBOL_GPL()s not used by modules Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155842eucas1p1aa92a260749305a13bebcd7999fd801b@eucas1p1.samsung.com>
2020-03-26 15:58 ` [PATCH v5 11/27] ata: fix CodingStyle issues in PATA timings code Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155843eucas1p19fd3210ca004306942c7c12ca98e04c2@eucas1p1.samsung.com>
2020-03-26 15:58 ` [PATCH v5 12/27] ata: separate PATA timings code from libata-core.c Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155843eucas1p1c3f378cfd16d7f2a29d46e1456d8cbfd@eucas1p1.samsung.com>
2020-03-26 15:58 ` [PATCH v5 13/27] ata: add CONFIG_SATA_HOST=n version of ata_ncq_enabled() Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155844eucas1p2e9676a4dd5205dc66c464cf8d9f4efb7@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 14/27] ata: let compiler optimize out ata_dev_config_ncq() on non-SATA hosts Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155844eucas1p264f9d573deb8bf9019e2e2d5cb59472b@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 15/27] ata: let compiler optimize out ata_eh_set_lpm() " Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155845eucas1p29de94fa9d541972b78334ebfd0055320@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 16/27] ata: start separating SATA specific code from libata-core.c Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155845eucas1p2cd33e166f3ac6ab47f4681385491f538@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 17/27] ata: move sata_scr_*() to libata-sata.c Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155845eucas1p170d540c74535517def9925bf9dffc0c7@eucas1p1.samsung.com>
2020-03-26 15:58 ` [PATCH v5 18/27] ata: move *sata_set_spd*() " Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155846eucas1p2c1a68a558be3f6df1308cd665ca60e32@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 19/27] ata: move sata_link_{debounce,resume}() " Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155846eucas1p26ed8a94105fa06625f4fd2c4a66f8960@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 20/27] ata: move sata_link_hardreset() " Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155847eucas1p1ed7286be9fa1a0616efc2d148bffe50d@eucas1p1.samsung.com>
2020-03-26 15:58 ` [PATCH v5 21/27] ata: move ata_qc_complete_multiple() " Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155847eucas1p274137b9af50464c076fbbfb45947493d@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 22/27] ata: move sata_deb_timing_*() " Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155847eucas1p2934ac7ef0c591dc15912b4d59d925d4c@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 23/27] ata: start separating SATA specific code from libata-scsi.c Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155848eucas1p2f3c45c3f3a26da7950118a88a1a65502@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 24/27] ata: move ata_sas_*() to libata-sata.c Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155848eucas1p1c9c2ca0451748cdfa4ab6a3420ab2847@eucas1p1.samsung.com>
2020-03-26 15:58 ` [PATCH v5 25/27] ata: start separating SATA specific code from libata-eh.c Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155849eucas1p1b7b96c8913106b0330344af0500aca99@eucas1p1.samsung.com>
2020-03-26 15:58 ` [PATCH v5 26/27] ata: move ata_eh_analyze_ncq_error() & co. to libata-sata.c Bartlomiej Zolnierkiewicz
[not found] ` <CGME20200326155849eucas1p2c1c0d059d5474597bd1eec3a6855ed8a@eucas1p2.samsung.com>
2020-03-26 15:58 ` [PATCH v5 27/27] ata: make "libata.force" kernel parameter optional Bartlomiej Zolnierkiewicz
2020-03-26 16:28 ` [PATCH v5 00/27] ata: optimize core code size on PATA only setups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326155822.19400-1-b.zolnierkie@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=axboe@kernel.dk \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).