From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Jim Paris <jim@jtan.com>, Geoff Levand <geoff@infradead.org>,
Joshua Morris <josh.h.morris@us.ibm.com>,
Philip Kelleher <pjk1939@linux.ibm.com>,
Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com,
linux-block@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
linux-nvdimm@lists.01.org
Subject: Re: remove a few uses of ->queuedata
Date: Sat, 9 May 2020 10:24:31 +0200 [thread overview]
Message-ID: <20200509082431.GC21834@lst.de> (raw)
In-Reply-To: <20200508221321.GD1389136@T590>
On Sat, May 09, 2020 at 06:13:21AM +0800, Ming Lei wrote:
> On Fri, May 08, 2020 at 06:15:02PM +0200, Christoph Hellwig wrote:
> > Hi all,
> >
> > various bio based drivers use queue->queuedata despite already having
> > set up disk->private_data, which can be used just as easily. This
> > series cleans them up to only use a single private data pointer.
> >
> > blk-mq based drivers that have code pathes that can't easily get at
> > the gendisk are unaffected by this series.
>
> Yeah, before adding disk, there still may be requests queued to LLD
> for blk-mq based drivers.
>
> So are there this similar situation for these bio based drivers?
bio submittsion is based on the gendisk, so we can't submit before
it is added. The passthrough request based path obviously doesn't apply
here.
prev parent reply other threads:[~2020-05-09 8:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 16:15 remove a few uses of ->queuedata Christoph Hellwig
2020-05-08 16:15 ` [PATCH 01/15] nfblock: use gendisk private_data Christoph Hellwig
2020-05-09 10:38 ` Geert Uytterhoeven
2020-05-08 16:15 ` [PATCH 02/15] simdisk: stop using ->queuedata Christoph Hellwig
2020-05-08 16:15 ` [PATCH 03/15] drbd: " Christoph Hellwig
2020-05-08 16:15 ` [PATCH 04/15] null_blk: stop using ->queuedata for bio mode Christoph Hellwig
2020-05-08 16:15 ` [PATCH 05/15] ps3vram: stop using ->queuedata Christoph Hellwig
2020-05-08 16:15 ` [PATCH 06/15] rsxx: " Christoph Hellwig
2020-05-08 16:15 ` [PATCH 07/15] umem: " Christoph Hellwig
2020-05-08 16:15 ` [PATCH 08/15] zram: " Christoph Hellwig
2020-05-08 16:15 ` [PATCH 09/15] lightnvm: " Christoph Hellwig
2020-05-09 8:38 ` [PATCH 09/15, fіxed] " Christoph Hellwig
2020-05-08 16:15 ` [PATCH 10/15] bcache: stop setting ->queuedata Christoph Hellwig
2020-05-08 16:15 ` [PATCH 11/15] dm: stop using ->queuedata Christoph Hellwig
2020-05-08 16:15 ` [PATCH 12/15] md: " Christoph Hellwig
2020-05-13 18:29 ` Song Liu
2020-05-13 18:33 ` Christoph Hellwig
2020-05-13 18:45 ` Song Liu
2020-05-08 16:15 ` [PATCH 13/15] nvdimm/blk: " Christoph Hellwig
2020-05-08 16:15 ` [PATCH 14/15] nvdimm/btt: " Christoph Hellwig
2020-05-08 16:15 ` [PATCH 15/15] nvdimm/pmem: " Christoph Hellwig
2020-05-08 18:04 ` remove a few uses of ->queuedata Dan Williams
2020-05-09 8:23 ` Christoph Hellwig
2020-05-09 15:07 ` Dan Williams
2020-05-12 8:08 ` Christoph Hellwig
2020-05-13 22:26 ` Dan Williams
2020-05-08 22:13 ` Ming Lei
2020-05-09 8:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509082431.GC21834@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=geoff@infradead.org \
--cc=jim@jtan.com \
--cc=josh.h.morris@us.ibm.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minchan@kernel.org \
--cc=ming.lei@redhat.com \
--cc=ngupta@vflare.org \
--cc=pjk1939@linux.ibm.com \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).