From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3C9C433DF for ; Wed, 20 May 2020 08:55:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F3C72075F for ; Wed, 20 May 2020 08:55:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="divgphGo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726733AbgETIz7 (ORCPT ); Wed, 20 May 2020 04:55:59 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:42760 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726224AbgETIz6 (ORCPT ); Wed, 20 May 2020 04:55:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589964957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=akmujYwqV7IKXWS2Az7WtujSNlNlXXC54n9CWBMtkzk=; b=divgphGoVneboFbjFfqrq17zz8+a62/zFp4zpTfO1Ca0GjF9mcQFJ4VLjg+OuS8BljjBhN 3vmeLKl+fS7EbMxT3sDcj0L41Wqemq5Tca0tQBJVoN/oWCNmy0PUx5e0aE5K+t9hwEDYG+ yh7BVnjCPE98JHn/zaLawk452tcZpgg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-380-a1dRF0yYMrCy_UyKRj--xg-1; Wed, 20 May 2020 04:55:51 -0400 X-MC-Unique: a1dRF0yYMrCy_UyKRj--xg-1 Received: by mail-wr1-f72.google.com with SMTP id e14so1108041wrv.11 for ; Wed, 20 May 2020 01:55:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=akmujYwqV7IKXWS2Az7WtujSNlNlXXC54n9CWBMtkzk=; b=OEUqZQX7rSBS2rPLh4D7gI9nXEP+Z+OY9g4bxmN5n+NUBEMEbcQcgG2DmtMFT1To3Z y6AIpDfXjkXeFeidANPhU/+hoONDUFIiSI3pyD3kuf7CLPzZlxJ7EQKgbOEky0W5zPxy sOwmJY76A8G757tUmvbAZixk7Fqdp9l0mL99f2LIjrV3VL/TbLkemjDdyJHuYAbBN+I5 YTGPxRgZ2rtnJTuqKwV+ikG9pII5zfXrXaESdo13YziRbBMtU/G48om1ay5l1SOv2m3e AqU/DjUzKsK35Kpxfr5/8K5usSej7EPVmR0B3fvD9obcFUflFSbA6FzkIgAIhMqH+ZPH 2csQ== X-Gm-Message-State: AOAM531XPBi3ojrFKfW9TS45v/f7MHEWk+CvcZU7fxk4uIOxoRNEXw3F uy+5wCSYROYoLharEMNwGWdSIk5hkl0DmFW5IpvSsTSK8aZ9r5XNwfFEgkL9m/jtRkYMbQU1jri X7yD/+408DuOvzjhtw2FF48edcHZn X-Received: by 2002:a1c:7d43:: with SMTP id y64mr3854355wmc.46.1589964949961; Wed, 20 May 2020 01:55:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPuljQ8ACnjmB5WsbRcDo1UAcpbT6hdWx3g2qAjmLnp22LP//Nkfq0hACI7Qm5NJJeVIUT0Q== X-Received: by 2002:a1c:7d43:: with SMTP id y64mr3854341wmc.46.1589964949786; Wed, 20 May 2020 01:55:49 -0700 (PDT) Received: from redhat.com (bzq-109-64-41-91.red.bezeqint.net. [109.64.41.91]) by smtp.gmail.com with ESMTPSA id v24sm2480851wmh.45.2020.05.20.01.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 01:55:49 -0700 (PDT) Date: Wed, 20 May 2020 04:55:47 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, kbuild test robot Subject: Re: [PATCH] m68k: add missing __user annotation in get_user() Message-ID: <20200520045441-mutt-send-email-mst@kernel.org> References: <20200520065750.8401-1-jasowang@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200520065750.8401-1-jasowang@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-m68k-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Wed, May 20, 2020 at 02:57:50PM +0800, Jason Wang wrote: > The ptr is a pointer to userspace memory. So we need annotate it with > __user otherwise we may get sparse warnings like: > > drivers/vhost/vhost.c:1603:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const *__gu_ptr @@ got unsigned int [noderef] [usertypvoid const *__gu_ptr @@ > drivers/vhost/vhost.c:1603:13: sparse: expected void const *__gu_ptr > drivers/vhost/vhost.c:1603:13: sparse: got unsigned int [noderef] [usertype] *idxp > > Cc: Geert Uytterhoeven > Cc: linux-m68k@lists.linux-m68k.org > Cc: linux-kernel@vger.kernel.org > Reported-by: kbuild test robot > Signed-off-by: Jason Wang Makes sense: Acked-by: Michael S. Tsirkin > --- > arch/m68k/include/asm/uaccess_mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/m68k/include/asm/uaccess_mm.h b/arch/m68k/include/asm/uaccess_mm.h > index 7e85de984df1..9ae9f8d05925 100644 > --- a/arch/m68k/include/asm/uaccess_mm.h > +++ b/arch/m68k/include/asm/uaccess_mm.h > @@ -142,7 +142,7 @@ asm volatile ("\n" \ > __get_user_asm(__gu_err, x, ptr, u32, l, r, -EFAULT); \ > break; \ > case 8: { \ > - const void *__gu_ptr = (ptr); \ > + const void __user *__gu_ptr = (ptr); \ > union { \ > u64 l; \ > __typeof__(*(ptr)) t; \ > -- > 2.20.1