From: Mike Rapoport <rppt@linux.ibm.com>
To: Angelo Dureghello <angelo.dureghello@timesys.com>
Cc: gerg@linux-m68k.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH] m68k: mm: fix node memblock init
Date: Mon, 15 Jun 2020 09:26:13 +0300 [thread overview]
Message-ID: <20200615062613.GA7811@linux.ibm.com> (raw)
In-Reply-To: <20200614225119.777702-1-angelo.dureghello@timesys.com>
Ho Angelo,
On Mon, Jun 15, 2020 at 12:51:19AM +0200, Angelo Dureghello wrote:
> After pulling 5.7.0 (linux-next merge), mcf5441x mmu boot was
> hanging silently.
>
> memblock_add() seems not appropriate, since using MAX_NUMNODES
> as node id, while memblock_add_node() sets up memory for node id 0.
>
> Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com>
The fix is correct, but it is not complete as nommu should be also
fixed.
I've updated your patch with nommu fix [1].
[1] https://lore.kernel.org/lkml/20200615062234.GA7882@kernel.org
> ---
> arch/m68k/mm/mcfmmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/mm/mcfmmu.c b/arch/m68k/mm/mcfmmu.c
> index 29f47923aa46..7d04210d34f0 100644
> --- a/arch/m68k/mm/mcfmmu.c
> +++ b/arch/m68k/mm/mcfmmu.c
> @@ -174,7 +174,7 @@ void __init cf_bootmem_alloc(void)
> m68k_memory[0].addr = _rambase;
> m68k_memory[0].size = _ramend - _rambase;
>
> - memblock_add(m68k_memory[0].addr, m68k_memory[0].size);
> + memblock_add_node(m68k_memory[0].addr, m68k_memory[0].size, 0);
>
> /* compute total pages in system */
> num_pages = PFN_DOWN(_ramend - _rambase);
> --
> 2.26.2
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-06-15 6:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 22:51 [PATCH] m68k: mm: fix node memblock init Angelo Dureghello
2020-06-15 6:26 ` Mike Rapoport [this message]
2020-06-15 9:16 ` Angelo Dureghello
2020-06-15 9:38 ` Angelo Dureghello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615062613.GA7811@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=angelo.dureghello@timesys.com \
--cc=gerg@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).