From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A9FC64E7B for ; Mon, 30 Nov 2020 15:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62266206CB for ; Mon, 30 Nov 2020 15:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726063AbgK3PbX (ORCPT ); Mon, 30 Nov 2020 10:31:23 -0500 Received: from mx2.suse.de ([195.135.220.15]:44188 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbgK3PbW (ORCPT ); Mon, 30 Nov 2020 10:31:22 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BF1DBAC8F; Mon, 30 Nov 2020 15:30:41 +0000 (UTC) Date: Mon, 30 Nov 2020 16:30:41 +0100 From: Daniel Wagner To: Sebastian Andrzej Siewior Cc: linux-scsi@vger.kernel.org, Finn Thain , GR-QLogic-Storage-Upstream@marvell.com, Hannes Reinecke , Jack Wang , John Garry , linux-m68k@lists.linux-m68k.org, Manish Rangankar , Michael Schmitz , MPT-FusionLinux.pdl@broadcom.com, Nilesh Javali , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , Vikram Auradkar , Xiang Chen , Xiaofei Tan , "James E . J . Bottomley" , "Martin K . Petersen" , Thomas Gleixner , "Ahmed S . Darwish" Subject: Re: [PATCH 13/14] scsi: message: fusion: Remove in_interrupt() usage in mpt_config(). Message-ID: <20201130153041.pj2p52upyuph5h2v@beryllium.lan> References: <20201126132952.2287996-1-bigeasy@linutronix.de> <20201126132952.2287996-14-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126132952.2287996-14-bigeasy@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Thu, Nov 26, 2020 at 02:29:51PM +0100, Sebastian Andrzej Siewior wrote: > From: Thomas Gleixner > > in_interrupt() is referenced all over the place in these drivers. Most of > these references are comments which are outdated and wrong. > > Aside of that in_interrupt() is deprecated as it does not provide what the > name suggests. It covers more than hard/soft interrupt servicing context > and is semantically ill defined. > > From reading the mpt_config() code and the history this is clearly a > debug mechanism and should probably be replaced by might_sleep() or > completely removed because such checks are already in the subsequent > functions. > > Remove the in_interrupt() references and replace the usage in > mpt_config() with might_sleep(). > > Signed-off-by: Thomas Gleixner > Signed-off-by: Sebastian Andrzej Siewior > Cc: Sathya Prakash > Cc: Sreekanth Reddy > Cc: Suganath Prabu Subramani > Cc: MPT-FusionLinux.pdl@broadcom.com Reviewed-by: Daniel Wagner