From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D849C48BC2 for ; Mon, 21 Jun 2021 20:41:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 646946124B for ; Mon, 21 Jun 2021 20:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230515AbhFUUnw (ORCPT ); Mon, 21 Jun 2021 16:43:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230447AbhFUUnu (ORCPT ); Mon, 21 Jun 2021 16:43:50 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 254CCC061574 for ; Mon, 21 Jun 2021 13:41:35 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvQjZ-0006Do-OA; Mon, 21 Jun 2021 22:41:29 +0200 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:eaae:20c7:f8b6:e250]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 09C85640B5B; Mon, 21 Jun 2021 20:41:27 +0000 (UTC) Date: Mon, 21 Jun 2021 22:41:27 +0200 From: Marc Kleine-Budde To: Geert Uytterhoeven Cc: Angelo Dureghello , Greg Ungerer , Wolfgang Grandegger , Linux/m68k , linux-can@vger.kernel.org, Joakim Zhang Subject: Re: [PATCH v3 4/5] can: flexcan: update Kconfig to allow non-of cases Message-ID: <20210621204127.xwrk2tlxggct7kst@pengutronix.de> References: <20210621184615.3345846-1-angelo@kernel-space.org> <20210621184615.3345846-4-angelo@kernel-space.org> <20210621201816.pk6n4xa7j4bi6vfk@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ixfdq6ieutri2tby" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-m68k@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org --ixfdq6ieutri2tby Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21.06.2021 22:22:50, Geert Uytterhoeven wrote: > Hi Marc, >=20 > On Mon, Jun 21, 2021 at 10:18 PM Marc Kleine-Budde w= rote: > > On 21.06.2021 22:11:58, Geert Uytterhoeven wrote: > > > On Mon, Jun 21, 2021 at 8:47 PM Angelo Dureghello > > > wrote: > > > > Update flexcan to support architectures without fdt. > > > > > > > > Signed-off-by: Angelo Dureghello > > > > --- > > > > Changes for v2: > > > > none > > > > Changes for v3: > > > > - change to just remove OF > > > > --- > > > > drivers/net/can/Kconfig | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig > > > > index e355d3974977..a0f4ae7ccb84 100644 > > > > --- a/drivers/net/can/Kconfig > > > > +++ b/drivers/net/can/Kconfig > > > > @@ -97,7 +97,7 @@ config CAN_AT91 > > > > > > > > config CAN_FLEXCAN > > > > tristate "Support for Freescale FLEXCAN based chips" > > > > - depends on OF && HAS_IOMEM > > > > + depends on HAS_IOMEM > > > > > > I think you want to add a line > > > > > > depends on ARCH_LAYERSCAPE || ARCH_MXC || COLDFIRE || > > > FSL_SOC_BOOKE || COMPILE_TEST > > > > > > (or PPC instead of FSL_SOC_BOOKE?) > > > so the question doesn't pop up when compiling a kernel for a system > > > that cannot have a Freescale FlexCAN IP block. > > > > Back in 2018 Pankaj Bansal replaced the "depends on ARM || PPC" by "OF > > && HAS_IOMEM", see: > > > > | 0f8af56f74cd can: flexcan: enable flexcan for all architectures >=20 > Probably the real reason behind that was to enable it on ARM64 > (more specifically ARCH_LAYERSCAPE || ARCH_MXC). Probably. What about the original proposed change: "(OF || M5441x) && HAS_I= OMEM"? > > So I think there won't be too many configs where the oldconfig question > > would pop up. >=20 > Now it will, as Mr. Torvalds' main machine does not satisfy "ARM || PPC" > or "OF && HAS_IOMEM", but does "HAS_IOMEM" ;-) IC, that would be one question too much :) Thanks, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --ixfdq6ieutri2tby Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmDQ+XQACgkQqclaivrt 76kuFwf+JzYbhrLHPWMBX6s+yJ2JWn7vzHK3/H6lOOIDO2eVnk4bQkKWGroYKIsW hTV1AtBhjnFCi67ZoIgFp8wLLJAbxCUJAops/bgYNfTih3INgANmPnmMr2Ky597e 9xZz8xiWlbLCKDATVDTB9xRXkI27rU/jhrMc1+9DCVSvz/s1To8OL+GIUVDMWkx7 t9AYpjOxkzWcYYB0IpIP8pjl+foDUro9um9JcovjSYStKggTGjWnFWduSmIsKarZ 1FtllhJ6Ge5V/fTtq/8Vehhc5r8DlAqwtltTwtpJcmEFOa0GvZ2feA9rzPq3/45X tzh+JT0zCtf04hISuAsbDs+TpsTj4g== =SZOD -----END PGP SIGNATURE----- --ixfdq6ieutri2tby--