linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <kch@nvidia.com>
To: <ogeert@linux-m68k.org>, <linux-block@vger.kernel.org>,
	<linux-m68k@lists.linux-m68k.org>, <linux-kernel@vger.kernel.org>,
	<drbd-dev@lists.linbit.com>, <nbd@other.debian.org>,
	<linux-mtd@lists.infradead.org>
Cc: <axboe@kernel.dk>, <philipp.reisner@linbit.com>,
	<lars.ellenberg@linbit.com>, <christoph.boehmwalder@linbit.com>,
	<efremov@linux.com>, <josef@toxicpanda.com>, <tim@cyberelk.net>,
	<haris.iqbal@ionos.com>, <jinpu.wang@ionos.com>, <richard@nod.at>,
	<miquel.raynal@bootlin.com>, <vigneshr@ti.com>, <kch@nvidia.com>,
	<mcgrof@kernel.org>, <hare@suse.de>,
	<damien.lemoal@opensource.wdc.com>, <johannes.thumshirn@wdc.com>,
	<bvanassche@acm.org>, <ming.lei@redhat.com>,
	<vincent.fu@samsung.com>, <shinichiro.kawasaki@wdc.com>
Subject: [RFC PATCH 18/18] ubi: use init disk helper
Date: Tue, 4 Oct 2022 22:00:27 -0700	[thread overview]
Message-ID: <20221005050027.39591-19-kch@nvidia.com> (raw)
In-Reply-To: <20221005050027.39591-1-kch@nvidia.com>

Add and use the helper to initialize the common fields of struct gendisk
such as major, first_minor, minors, disk_name, private_data, and ops.
This initialization is spread all over the block drivers. This avoids
code repetation of inialization code of gendisk in current block drivers
and any future ones.

Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
 drivers/mtd/ubi/block.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
index 4cf67a2a0d04..07c085a5fd52 100644
--- a/drivers/mtd/ubi/block.c
+++ b/drivers/mtd/ubi/block.c
@@ -420,9 +420,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
 		goto out_free_tags;
 	}
 
-	gd->fops = &ubiblock_ops;
-	gd->major = ubiblock_major;
-	gd->minors = 1;
+	init_disk(gd, ubiblock_major, 1, 0, disk_capacity, dev, &ubiblock_ops);
 	gd->first_minor = idr_alloc(&ubiblock_minor_idr, dev, 0, 0, GFP_KERNEL);
 	if (gd->first_minor < 0) {
 		dev_err(disk_to_dev(gd),
@@ -431,9 +429,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
 		goto out_cleanup_disk;
 	}
 	gd->flags |= GENHD_FL_NO_PART;
-	gd->private_data = dev;
 	sprintf(gd->disk_name, "ubiblock%d_%d", dev->ubi_num, dev->vol_id);
-	set_capacity(gd, disk_capacity);
 	dev->gd = gd;
 
 	dev->rq = gd->queue;
-- 
2.29.0


      parent reply	other threads:[~2022-10-05  5:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05  5:00 [RFC PATCH 00/18] block: add and use init disk helper Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 01/18] " Chaitanya Kulkarni
2022-10-10  7:59   ` Christoph Hellwig
2022-10-05  5:00 ` [RFC PATCH 02/18] nfblock: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 03/18] amiflop: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 04/18] brd: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 05/18] drbd: " Chaitanya Kulkarni
2022-10-05 10:09   ` Christoph Böhmwalder
2022-10-05 17:24     ` Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 06/18] floppy: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 07/18] loop: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 08/18] n64cart: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 09/18] nbd: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 10/18] pcd: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 11/18] pd: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 12/18] pf: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 13/18] pktcdvd: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 14/18] rnbd-clt: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 15/18] swim: " Chaitanya Kulkarni
2022-10-05  6:54   ` Finn Thain
2022-10-05  5:00 ` [RFC PATCH 16/18] swim3: " Chaitanya Kulkarni
2022-10-05  5:00 ` [RFC PATCH 17/18] z2ram: " Chaitanya Kulkarni
2022-10-05  5:00 ` Chaitanya Kulkarni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221005050027.39591-19-kch@nvidia.com \
    --to=kch@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=christoph.boehmwalder@linbit.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=efremov@linux.com \
    --cc=hare@suse.de \
    --cc=haris.iqbal@ionos.com \
    --cc=jinpu.wang@ionos.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=josef@toxicpanda.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mcgrof@kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=nbd@other.debian.org \
    --cc=ogeert@linux-m68k.org \
    --cc=philipp.reisner@linbit.com \
    --cc=richard@nod.at \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=tim@cyberelk.net \
    --cc=vigneshr@ti.com \
    --cc=vincent.fu@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).