From: Greg Ungerer <gerg@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH 3/3] m68k: allow kexec on all MMU enabled CPUs
Date: Tue, 30 Aug 2022 17:23:19 +1000 [thread overview]
Message-ID: <337d70c9-5257-a9d4-5ec1-a43b8ade1a14@linux-m68k.org> (raw)
In-Reply-To: <CAMuHMdWRjG6n9MpLG+rZtyrTPdj6sGLt7LehHo+i0P9aHach+Q@mail.gmail.com>
Hi Geert,
On 26/8/22 17:44, Geert Uytterhoeven wrote:
> On Fri, Aug 26, 2022 at 6:08 AM Greg Ungerer <gerg@linux-m68k.org> wrote:
>> The configuration setting for 68k kexec support limits it to only
>> the classic 68k CPU types (so no ColdFire). However the underlying
>> support can handle any 68k CPU that is MMU enabled - and that includes
>> ColdFire. (Of course that support is only as good as mentioned in
>> the current configuration help).
>>
>> None of the no-MMU CPU types (classic or ColdFire) have support for
>> kexec yet, so the configuration as it stands is not quite right, and
>> it will fail to compile on them.
>>
>> Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
>
> Thanks for your patch!
>
>> --- a/arch/m68k/Kconfig
>> +++ b/arch/m68k/Kconfig
>> @@ -87,7 +87,7 @@ config MMU_SUN3
>>
>> config KEXEC
>> bool "kexec system call"
>> - depends on M68KCLASSIC
>> + depends on MMU
>> select KEXEC_CORE
>> help
>> kexec is a system call that implements the ability to shutdown your
>
> Don't you need changes to arch/m68k/kernel/relocate_kernel.S,
> which supports 68020+ only?
I suspect so looking at that now. It compiles ok, but without a
check for MMU type specific to ColdFire it will likely fail.
I didn't dig into it too deeply, my primary goal with to fix compilation
for the non-MMU targets.
I started out testing it with this:
depends on M68KCLASSIC && MMU
And that works and fixes the problem I was most interested in.
But then I figured that perhaps it is better to allow if for ColdFire with MMU enabled.
I didn't want to go down the rabbit hole of trying to get it working
on non-MMU platforms (and ColdFire with MMU enabled either really).
So I would be just as happy to limit it to M68KCLASSIC and MMU for now?
Regards
Greg
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2022-08-30 7:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 4:03 [PATCH 1/3] m68knommu: fix non-specific 68328 choice interrupt build failure Greg Ungerer
2022-08-26 4:03 ` [PATCH 2/3] m68knommu: fix non-mmu classic 68000 legacy timer tick selection Greg Ungerer
2022-08-26 7:39 ` Geert Uytterhoeven
2022-08-26 4:03 ` [PATCH 3/3] m68k: allow kexec on all MMU enabled CPUs Greg Ungerer
2022-08-26 7:44 ` Geert Uytterhoeven
2022-08-30 7:23 ` Greg Ungerer [this message]
2022-08-30 7:36 ` Geert Uytterhoeven
2022-08-26 7:38 ` [PATCH 1/3] m68knommu: fix non-specific 68328 choice interrupt build failure Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=337d70c9-5257-a9d4-5ec1-a43b8ade1a14@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).