From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A226016D326 for ; Fri, 5 Apr 2024 16:20:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712334023; cv=none; b=AdrHaGquIBeE1VYPJoXeT+j6pafJDdaneJ3n03R/ybdf96Iacdy3kmUB+luXONESbIU+VKLSIB2MaMPIw/Bp4Dss79/i4TU/fiK1hSltHYaG2CzTygY/zb3qtSoloUq7isnNk5qggnl6uaBz7MDQ0FlhdKFtZyf3/9f8lbmcCRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712334023; c=relaxed/simple; bh=STODT/c3z6ypoEyUkP1OAtZ6EfyLMQK08sm/bPAw1AU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bpCe1wr+PhrXcDLHMINC/2k3Hfz7yUiqrhZCFfQQwCsrEXp/a/fYnvuxwHxGt9pQtCawtRIofy9vFYuMuZLcSey5CbBMeUTlfFuT95YLKbh/ZmuFctV1pxRayk6ulrG4Uxdt71HFIqxABpWkSwSSJPo471TRVEp1IfONY+SVDVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=C/HZKJyO; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="C/HZKJyO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712334022; x=1743870022; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=STODT/c3z6ypoEyUkP1OAtZ6EfyLMQK08sm/bPAw1AU=; b=C/HZKJyOXQsAnQLLdmXcHCDA1Oj9zUYbkZJI3PKPtdR14MbisCDrDaB2 r5e0RsjB6CgPAD5n2FAuURvNDJscUSlVjKokVsRNBfzkvdkx/VLPo9jfr wcHaxJyEPoE4BNO5SbRekOeDN5GSNg05N0VwD/Ng42ZTgkYG35vq4jCPu welg7W7cuKNTu+rsVkPVQ5ccEpLGhuJtyfJuzysb5SzSEBfAMujObO0Q3 y/sW3at4rgzjODiCno7yi00nesMOHXwWrH9DI22WB5RTSxtst9rA0vBuT OhlrFWlej/VLezTiY2N7B719jUixuNzr9T9FCWGZH1ExFDb2FLOrYaz0t w==; X-CSE-ConnectionGUID: rZ7sxBxcSk2Y2qvSYdSi8w== X-CSE-MsgGUID: ksQTZu6RQvOA3+lOkBsG+w== X-IronPort-AV: E=McAfee;i="6600,9927,11035"; a="11462798" X-IronPort-AV: E=Sophos;i="6.07,181,1708416000"; d="scan'208";a="11462798" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2024 09:20:21 -0700 X-CSE-ConnectionGUID: EGOUsw1jS4iffZcF7In7vA== X-CSE-MsgGUID: OzVkpaElRkSa/fAWFgBa3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,181,1708416000"; d="scan'208";a="19141333" Received: from ahajda-mobl.ger.corp.intel.com (HELO [10.245.80.70]) ([10.245.80.70]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2024 09:20:15 -0700 Message-ID: <340d23fc-7abf-4ad0-bd95-f1760b9ac458@intel.com> Date: Fri, 5 Apr 2024 18:20:11 +0200 Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-gfx] [PATCH v5 0/7] Introduce __xchg, non-atomic xchg To: Jani Nikula , Peter Zijlstra Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-snps-arc@lists.infradead.org, intel-gfx@lists.freedesktop.org, linux-xtensa@linux-xtensa.org, Arnd Bergmann , Boqun Feng , linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, loongarch@lists.linux.dev, Rodrigo Vivi , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linux-alpha@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org References: <20230118153529.57695-1-andrzej.hajda@intel.com> <17f40b7c-f98d-789d-fa19-12ec077b756a@intel.com> <87r0fjc1cz.fsf@intel.com> Content-Language: en-US From: Andrzej Hajda Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <87r0fjc1cz.fsf@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05.04.2024 16:47, Jani Nikula wrote: > On Mon, 27 Feb 2023, Peter Zijlstra wrote: >> On Thu, Feb 23, 2023 at 10:24:19PM +0100, Andrzej Hajda wrote: >>> On 22.02.2023 18:04, Peter Zijlstra wrote: >>>> On Wed, Jan 18, 2023 at 04:35:22PM +0100, Andrzej Hajda wrote: >>>> >>>>> Andrzej Hajda (7): >>>>> arch: rename all internal names __xchg to __arch_xchg >>>>> linux/include: add non-atomic version of xchg >>>>> arch/*/uprobes: simplify arch_uretprobe_hijack_return_addr >>>>> llist: simplify __llist_del_all >>>>> io_uring: use __xchg if possible >>>>> qed: use __xchg if possible >>>>> drm/i915/gt: use __xchg instead of internal helper >>>> Nothing crazy in here I suppose, I somewhat wonder why you went through >>>> the trouble, but meh. >>> If you are asking why I have proposed this patchset, then the answer is >>> simple, 1st I've tried to find a way to move internal i915 helper to core >>> (see patch 7). >>> Then I was looking for possible other users of this helper. And apparently >>> there are many of them, patches 3-7 shows some. >>> >>> >>>> You want me to take this through te locking tree (for the next cycle, >>>> not this one) where I normally take atomic things or does someone else >>>> want this? >>> If you could take it I will be happy. >> OK, I'll go queue it in tip/locking/core after -rc1. Thanks! > Is this where the series fell between the cracks, or was there some > follow-up that I missed? > > I think this would still be useful. Andrzej, would you mind rebasing and > resending if there are no objections? The patchset was rejected/dropped by Linus at the pull-request stage. He didn't like many things, but the most __xchg name. However he was quite positive about i915 name fetch_and_zero. I can try to revive patchset with fetch_and_zero, and maybe fetch_and_set, instead of __xchg. Regards Andrzej > > BR, > Jani. > >