From: John Paul Adrian Glaubitz <glaubitz-1Olz3AKvcsuAKZTfuerNgRvVK+yQ3ZXh@public.gmane.org>
To: Phillip Susi <psusi-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
Cc: Parted development
<parted-devel-XbBxUvOt3X2LieD7tvxI8l/i77bcL1HB@public.gmane.org>,
Linux/m68k <linux-m68k-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Debian m68k <debian-68k-0aAXYlwwYIJuHlm7Suoebg@public.gmane.org>
Subject: Re: Atari label false positives
Date: Fri, 11 May 2018 18:10:37 +0200 [thread overview]
Message-ID: <461cde4a-4cc2-8dce-538d-2c2af21e5ba3@physik.fu-berlin.de> (raw)
In-Reply-To: <874bf955-d5bc-5d9c-0f87-445da67f3bdd-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
On 05/11/2018 05:56 PM, Phillip Susi wrote:
> On 5/11/2018 11:29 AM, John Paul Adrian Glaubitz wrote:
>> Thanks for digging this up. I wasn't aware of this particular issue before
>> and I agree, this needs to be addressed. I hope that I didn't cause too
>> many DOS partitions to be misdetected. Sorry for the inconvenience if I
>> did. The Atari partition table code has been working great for
>> Debian/m68k so
>> far though.
>
> I have seen at least one or two reports of Ubuntu users getting false
> positives, and then I saw the bug report on the upstream parted bug
> tracker the other day where someone claimed to have found a logical
> error that caused atari_probe to return true when it shouldn't. I
> finally realized it was not an error ( at least I think not ).
According to the documentation, p.43 [1], I think offset $01 should always
contain either "GEM", "BGM" or "XGM". They don't seem to be optional.
I guess adding those to atari_probe() should help improve the detection
quite a bit. But I would have to test that first.
> I think I will at least move atari to be probed after all other labels
> have failed.
This sounds like a reasonable thing to do until I have worked out
a patch to improve atari_probe().
Adrian
> [1] https://people.debian.org/~glaubitz/Atari_HD_File_Sytem_Reference_Guide.pdf
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org
`. `' Freie Universitaet Berlin - glaubitz-1Olz3AKvcsuAKZTfuerNgRvVK+yQ3ZXh@public.gmane.org
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2018-05-11 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2d6f5455-963d-b044-a64d-67634df46071@ubuntu.com>
[not found] ` <2d6f5455-963d-b044-a64d-67634df46071-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2018-05-11 15:29 ` Atari label false positives John Paul Adrian Glaubitz
[not found] ` <35ad9889-bc13-56bd-7831-f7bb3eea2d1e-1Olz3AKvcsuAKZTfuerNgRvVK+yQ3ZXh@public.gmane.org>
2018-05-11 15:56 ` Phillip Susi
[not found] ` <874bf955-d5bc-5d9c-0f87-445da67f3bdd-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2018-05-11 16:10 ` John Paul Adrian Glaubitz [this message]
2018-05-11 18:30 ` [parted-devel] " Richard Z
2018-05-11 23:17 ` Michael Schmitz
[not found] ` <80a28dd6-ce19-e6ed-fc7a-c5561fecf989-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-05-12 7:59 ` John Paul Adrian Glaubitz
2018-05-12 8:41 ` [parted-devel] " Michael Schmitz
[not found] ` <c1bf0748-f7e0-b109-8c9e-26f8a2c70bf3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-05-12 11:24 ` John Paul Adrian Glaubitz
2018-05-12 19:22 ` [parted-devel] " Michael Schmitz
2018-05-14 13:02 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461cde4a-4cc2-8dce-538d-2c2af21e5ba3@physik.fu-berlin.de \
--to=glaubitz-1olz3akvcsuakztfuerngrvvk+yq3zxh@public.gmane.org \
--cc=debian-68k-0aAXYlwwYIJuHlm7Suoebg@public.gmane.org \
--cc=linux-m68k-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=parted-devel-XbBxUvOt3X2LieD7tvxI8l/i77bcL1HB@public.gmane.org \
--cc=psusi-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).