From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v4] ata/pata_buddha: Probe via modalias instead of initcall Date: Mon, 12 Aug 2019 12:42:13 +0200 Message-ID: <4729c030-549e-8797-f947-1620cd61d516@samsung.com> References: <20190811153643.12029-1-max@enpas.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Max Staudt Cc: axboe@kernel.dk, linux-ide@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, glaubitz@physik.fu-berlin.de, schmitzmic@gmail.com, geert@linux-m68k.org List-Id: linux-m68k@vger.kernel.org On 8/11/19 9:28 PM, Max Staudt wrote: > Replying to my own patch with two more questions: > > > On 08/11/2019 05:36 PM, Max Staudt wrote: >> - /* allocate host */ >> - host = ata_host_alloc(&z->dev, nr_ports); > > Actually, this is an issue even the existing pata_buddha has: ata_host_alloc()> will dev_set_drvdata(dev, host) which is fine on Buddha and Catweasel, bu> conflicts with zorro8390's own dev_set_drvdata() on an X-Surf board. Thus, > if both pata_buddha and zorro8390 are active, only one can be unloaded. The > original ide/buddha driver does not have this problem as far as I can see. ide/buddha driver cannot be unloaded currently (it lacks module_exit()). > This should be resolved once we get around to MFD support, as Geert suggested. > > Shall we leave this as-is, as it's not really a change from the status quo in > pata_buddha? pata_buddha also cannot be unloaded currently (also lacks module_exit()), I think that we should leave it as it is until MFD support is added. >> +static int __init pata_buddha_late_init(void) >> +{ >> + struct zorro_dev *z = NULL; >> + >> + pr_info("pata_buddha: Scanning for stand-alone IDE controllers...\n"); >> + zorro_register_driver(&pata_buddha_driver); >> + >> + pr_info("pata_buddha: Scanning for X-Surf boards...\n"); >> + while ((z = zorro_find_device(ZORRO_PROD_INDIVIDUAL_COMPUTERS_X_SURF, z))) { >> + static struct zorro_device_id xsurf_ent = >> + { ZORRO_PROD_INDIVIDUAL_COMPUTERS_X_SURF, BOARD_XSURF}; >> + >> + pata_buddha_probe(z, &xsurf_ent); >> + } >> + >> + return 0; >> +} > > This is suboptimal, as we don't release memory in case pata_buddha_probe() > fails. Any suggestions? It should work exactly like the old code in case of X-Surf, what do we need to release? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics