From: Michael Schmitz <schmitzmic@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>,
linux-ide@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH RESEND v2 1/2] m68k/atari: add platform device for Falcon IDE port
Date: Tue, 5 Nov 2019 10:09:26 +1300 [thread overview]
Message-ID: <4cb95fe6-c2ea-0195-9124-fc2e1223ab38@gmail.com> (raw)
In-Reply-To: <CAMuHMdULi8F8Ky4VxiQew25p5vOTQuf1tXrg7Dx-6aRu1Tj3qw@mail.gmail.com>
Hi Geert,
thanks for your review!
On 4/11/19 11:56 PM, Geert Uytterhoeven wrote:
> Hi Michael,
>
> On Thu, Sep 26, 2019 at 5:54 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>> Autoloading of Falcon IDE driver modules requires converting
>> these drivers to platform drivers.
>>
>> Add platform device for Falcon IDE interface in Atari platform
>> setup code in preparation for this.
>>
>> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
>>
>> --
> This should be a triple dash.
>
>> Changes from RFC
>>
>> - fix region size (spotted by Szymon Bieganski <S.Bieganski@chello.nl>)
>> - define IDE interface address in atari/config.c, create platform device
>> always (suggested by Geert Uytterhoeven <geert@linux-m68k.org>)
>>
>> Changes from v1
>>
>> - add error checking for Falcon IDE platform device register
> Thanks for the update!
>
>> --- a/arch/m68k/atari/config.c
>> +++ b/arch/m68k/atari/config.c
>> @@ -939,6 +959,13 @@ int __init atari_platform_init(void)
>> atari_scsi_tt_rsrc, ARRAY_SIZE(atari_scsi_tt_rsrc));
>> #endif
>>
>> + if (ATARIHW_PRESENT(IDE)) {
>> + pdev = platform_device_register_simple("atari-falcon-ide", -1,
>> + atari_falconide_rsrc, ARRAY_SIZE(atari_falconide_rsrc));
>> + if (IS_ERR(pdev))
>> + rv = PTR_ERR(pdev);
>> + }
>> +
>> return rv;
>> }
> This breaks both falconide and pata_falcon, as it marks the resource
> busy:
>
> ide: Falcon IDE controller
> falconide: resources busy
>
> and
>
> pata_falcon: Atari Falcon PATA controller
> pata_falcon: resources busy
>
> For pata_falcon, that regression can easily be fixed by merging both patches.
I obviously need to test this again, but from what I remember from my
last testing, falconide still worked OK after applying both patches.
That would have been without loading pata_falcon at all.
I'll rewrite falconide to use the same platform device as pata_falcon.
Cheers,
Michael
> For falconide, I think the sensible thing to do is just remove the driver.
> But before that, the defconfigs should be updated to use pata_falcon
> instead of falconide.
>
> For the actual code changes:
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Gr{oetje,eeting}s,
>
> Geert
>
next prev parent reply other threads:[~2019-11-04 21:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1569470064-3977-1-git-send-email-schmitzmic@gmail.com>
2019-10-25 20:33 ` [PATCH RESEND v2 0/2] Convert Atari Falcon IDE driver to platform device Jens Axboe
2019-10-26 18:17 ` Geert Uytterhoeven
2019-10-28 7:03 ` Michael Schmitz
2019-11-04 11:04 ` Geert Uytterhoeven
2019-11-04 19:17 ` Michael Schmitz
2019-11-04 20:06 ` Geert Uytterhoeven
2019-11-04 21:10 ` John Paul Adrian Glaubitz
2019-11-04 21:21 ` Michael Schmitz
2019-11-04 21:42 ` John Paul Adrian Glaubitz
2019-11-05 6:57 ` Michael Schmitz
2019-11-06 1:34 ` Michael Schmitz
[not found] ` <1569470064-3977-2-git-send-email-schmitzmic@gmail.com>
2019-11-04 10:56 ` [PATCH RESEND v2 1/2] m68k/atari: add platform device for Falcon IDE port Geert Uytterhoeven
2019-11-04 21:09 ` Michael Schmitz [this message]
2019-11-05 6:37 ` [PATCH] ide: falconide: convert to platform driver Michael Schmitz
2019-11-05 8:11 ` Geert Uytterhoeven
2019-11-05 18:31 ` Michael Schmitz
2019-11-05 18:46 ` Geert Uytterhoeven
2019-11-05 20:02 ` Michael Schmitz
2019-11-05 21:13 ` Michael Schmitz
2019-11-05 21:43 ` Geert Uytterhoeven
2019-11-06 1:35 ` Michael Schmitz
2019-11-05 6:43 ` [PATCH RESEND v2 1/2] m68k/atari: add platform device for Falcon IDE port Michael Schmitz
[not found] ` <1569470064-3977-3-git-send-email-schmitzmic@gmail.com>
2019-11-04 10:58 ` [PATCH RESEND v2 2/2] drivers/ata: convert pata_falcon to arch platform device Geert Uytterhoeven
2019-11-06 2:47 ` [PATCH v3] m68k/atari: convert legacy Falcon IDE driver to platform driver Michael Schmitz
2019-11-18 9:20 ` Geert Uytterhoeven
2019-11-18 9:41 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cb95fe6-c2ea-0195-9124-fc2e1223ab38@gmail.com \
--to=schmitzmic@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).