linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phillip Susi <psusi-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
To: "Håkon Løvdal" <hlovdal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: GNU Parted developers' list
	<parted-devel-XbBxUvOt3X2LieD7tvxI8l/i77bcL1HB@public.gmane.org>,
	linux-m68k-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	debian-68k-0aAXYlwwYIJuHlm7Suoebg@public.gmane.org
Subject: Re: [PATCH] Fix atari label false positives
Date: Wed, 6 Jun 2018 09:14:09 -0400	[thread overview]
Message-ID: <5f780c27-97f5-a42f-77c1-65c3b7b52078@ubuntu.com> (raw)
In-Reply-To: <CAACXqO8f-=-Bj6JiddnQM5GMFenDUj-MBO7ZTUcPh1tAKWtTmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 399 bytes --]

On 6/5/2018 4:08 PM, Håkon Løvdal wrote:
> While the commit message contains the relevant information, this really
> ought to be present as a comment directly in the code as well. And
> the un-obviousness of the code vs check order deserves a mention as
> well, so please add a commen like
> 
> +       ped_disk_atari_init (); // NB! Must be first so that it is checked last.

Will do.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      parent reply	other threads:[~2018-06-06 13:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 14:30 [PATCH] Fix atari label false positives Phillip Susi
     [not found] ` <20180605143045.23875-1-psusi-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2018-06-05 14:35   ` John Paul Adrian Glaubitz
2018-06-05 14:40     ` Phillip Susi
     [not found]       ` <208fded9-0bfc-0578-7a57-98b5c3af78dc-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2018-06-05 14:43         ` John Paul Adrian Glaubitz
2018-06-05 20:08   ` Håkon Løvdal
     [not found]     ` <CAACXqO8f-=-Bj6JiddnQM5GMFenDUj-MBO7ZTUcPh1tAKWtTmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-06 13:14       ` Phillip Susi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f780c27-97f5-a42f-77c1-65c3b7b52078@ubuntu.com \
    --to=psusi-gewih/nmzzlqt0dzr+alfa@public.gmane.org \
    --cc=debian-68k-0aAXYlwwYIJuHlm7Suoebg@public.gmane.org \
    --cc=hlovdal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-m68k-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=parted-devel-XbBxUvOt3X2LieD7tvxI8l/i77bcL1HB@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).