From: miaoqinglang <miaoqinglang@huawei.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] m68k/amiga: missing platform_device_unregister() on error in amiga_init_devices()
Date: Sat, 19 Sep 2020 09:30:51 +0800 [thread overview]
Message-ID: <613d3a43-4fb0-48d5-93d6-bf0d8f0bd671@huawei.com> (raw)
In-Reply-To: <CAMuHMdWfqh_AKyE+od_0yVPP6Lkv8LUAR1dWf8Df94W7b4qxLA@mail.gmail.com>
在 2020/8/26 17:07, Geert Uytterhoeven 写道:
> Hi Qinglang,
>
> On Tue, Jul 28, 2020 at 4:24 AM Qinglang Miao <miaoqinglang@huawei.com> wrote:
>> Add the missing platform_device_unregister() before return
>> from amiga_init_devices() in the error handling case.
>>
>> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
>
> Thanks for your patch!
>
>> --- a/arch/m68k/amiga/platform.c
>> +++ b/arch/m68k/amiga/platform.c
>> @@ -188,8 +188,10 @@ static int __init amiga_init_devices(void)
>> return PTR_ERR(pdev);
>> error = platform_device_add_data(pdev, &a1200_ide_pdata,
>> sizeof(a1200_ide_pdata));
>
> The only reason why platform_device_add_data() can fail is because the
> system ran out of memory. If that's the case this early, the whole
> system will fail to work anyway, and it doesn't matter that the IDE
> driver will crash later due to missing platform data.
>
> So I don't think it helps to increase kernel size by adding more error
> handling.
>
Hi Geert,
Glad to know your opnions, it sounds resonable to me.
Thanks.
>> - if (error)
>> + if (error) {
>> + platform_device_unregister(pdev);
>> return error;
>> + }
>> }
>>
>> if (AMIGAHW_PRESENT(A4000_IDE)) {
>> @@ -199,8 +201,10 @@ static int __init amiga_init_devices(void)
>> return PTR_ERR(pdev);
>> error = platform_device_add_data(pdev, &a4000_ide_pdata,
>> sizeof(a4000_ide_pdata));
>> - if (error)
>> + if (error) {
>> + platform_device_unregister(pdev);
>
> Likewise.
>
>> return error;
>> + }
>
> Gr{oetje,eeting}s,
>
> Geert
>
prev parent reply other threads:[~2020-09-19 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 2:27 [PATCH -next] m68k/amiga: missing platform_device_unregister() on error in amiga_init_devices() Qinglang Miao
2020-08-26 9:07 ` Geert Uytterhoeven
2020-09-19 1:30 ` miaoqinglang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=613d3a43-4fb0-48d5-93d6-bf0d8f0bd671@huawei.com \
--to=miaoqinglang@huawei.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).