linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Max Staudt <max@enpas.org>
Cc: axboe@kernel.dk, linux-ide@vger.kernel.org,
	linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
	glaubitz@physik.fu-berlin.de, schmitzmic@gmail.com,
	geert@linux-m68k.org
Subject: Re: [PATCH v5] ata/pata_buddha: Probe via modalias instead of initcall
Date: Tue, 20 Aug 2019 18:54:16 +0200	[thread overview]
Message-ID: <75af4479-da1c-9f5f-cff1-1428065ea4ad@samsung.com> (raw)
In-Reply-To: <89894d50-0e3c-4d43-37b2-ff5be407e58c@enpas.org>


On 8/20/19 5:59 PM, Max Staudt wrote:
> Hi Bartlomiej,
> 
> Thank you very much for your review!
> 
> Question below.
> 
> 
> On 08/20/2019 02:06 PM, Bartlomiej Zolnierkiewicz wrote:
>>> +	/* Workaround for X-Surf: Save drvdata in case zorro8390 has set it */
>>> +	old_drvdata = dev_get_drvdata(&z->dev);
>>
>> This should be done only for type == BOARD_XSURF.
> 
> Agreed, as I want to keep unloading functional for Buddha/Catweasel - see below.
> 
> 
>>> +static struct zorro_driver pata_buddha_driver = {
>>> +	.name           = "pata_buddha",
>>> +	.id_table       = pata_buddha_zorro_tbl,
>>> +	.probe          = pata_buddha_probe,
>>> +	.remove         = pata_buddha_remove,
>>
>> I think that we should also add:
>>
>> 	.driver  = {
>> 		.suppress_bind_attrs = true,
>> 	},
>>
>> to prevent the device from being unbinded (and thus ->remove called)
>> from the driver using sysfs interface.
> 
> Interesting idea - here's my question now:
> 
> My intention is to allow remove() for boards where we support IDE only (Buddha, Catweasel) - these are autoprobed via zorro_register_driver().
> This shouldn't affect the X-Surf case, as it's not autoprobed in this way anyway - and thus pata_buddha_driver isn't even used.
> 
> Am I missing something? We want to inhibit module unloading (hence no module_exit()), but driver unbinding for Buddha/Catweasel should be fine to remain, right?

Indeed, pata_buddha_driver is not even used for X-Surf so this is not
an issue (please disregard my comment about suppress_bind_attrs).

>> Please also always check your patches with scripts/checkpatch.pl and
>> fix the reported issues:
> 
> Apologies, must've been something in my coffee. I will.
> 
> 
> Thanks for the review, I'll send a new patch once my question above is resolved.
> 
> Max
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

  reply	other threads:[~2019-08-20 16:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190812164840epcas2p4b88d3ebaf313f0c99ccb693047bce04c@epcas2p4.samsung.com>
2019-08-12 16:48 ` Max Staudt
2019-08-12 16:51   ` Max Staudt
2019-08-20 12:06   ` Bartlomiej Zolnierkiewicz
2019-08-20 15:59     ` Max Staudt
2019-08-20 16:54       ` Bartlomiej Zolnierkiewicz [this message]
2019-08-20 16:42     ` Max Staudt
2019-08-20 16:55       ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75af4479-da1c-9f5f-cff1-1428065ea4ad@samsung.com \
    --to=b.zolnierkie@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=geert@linux-m68k.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=max@enpas.org \
    --cc=schmitzmic@gmail.com \
    --subject='Re: [PATCH v5] ata/pata_buddha: Probe via modalias instead of initcall' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).