From: "Arnd Bergmann" <arnd@arndb.de>
To: "Baoquan He" <bhe@redhat.com>, "Michael Ellerman" <mpe@ellerman.id.au>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-sh@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org,
"Christoph Hellwig" <hch@infradead.org>,
linux-mm@kvack.org, "Luis Chamberlain" <mcgrof@kernel.org>,
linux-parisc@vger.kernel.org, linux-alpha@vger.kernel.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 2/2] arch/*/io.h: remove ioremap_uc in some architectures
Date: Tue, 07 Mar 2023 08:17:30 +0100 [thread overview]
Message-ID: <9d8292ad-c865-4b82-b6e3-d7db75820d0f@app.fastmail.com> (raw)
In-Reply-To: <ZAaTw+841xBsz/m9@MiWiFi-R3L-srv>
On Tue, Mar 7, 2023, at 02:30, Baoquan He wrote:
> On 03/07/23 at 11:58am, Michael Ellerman wrote:
>> "Arnd Bergmann" <arnd@arndb.de> writes:
>> > On Sun, Mar 5, 2023, at 10:29, Geert Uytterhoeven wrote:
>> >> On Sun, Mar 5, 2023 at 10:23 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
>> >>> Maybe that exact code path is only reachable on x86/ia64? But if so
>> >>> please explain why.
>> >>>
>> >>> Otherwise it looks like this series could break that driver on powerpc
>> >>> at least.
>> >>
>> >> Indeed.
>> >
>> > When I last looked into this, I sent a patch to use ioremap()
>> > on non-x86:
>> >
>> > https://lore.kernel.org/all/20191111192258.2234502-1-arnd@arndb.de/
>>
>> OK thanks.
>>
>> Baoquan can you add that patch to the start of this series if/when you
>> post the next version?
>
> Sure, will do. Wondering if we need make change to cover powerpc other
> than x86 and ia64 in Arnd's patch as you and Geert pointed out.
The patch fixes the aty driver for all architectures, including the
ones that were already broken before your series with the 'return NULL'
version.
The only other callers of ioremap_uc() and devm_ioremap_uc() are
in architecture specific code and in drivers/mfd/intel-lpss.c, which
is x86 specific.
Arnd
prev parent reply other threads:[~2023-03-07 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230303102817.212148-1-bhe@redhat.com>
2023-03-03 10:28 ` [PATCH v3 2/2] arch/*/io.h: remove ioremap_uc in some architectures Baoquan He
2023-03-05 9:23 ` Michael Ellerman
2023-03-05 9:29 ` Geert Uytterhoeven
2023-03-05 20:10 ` Arnd Bergmann
2023-03-07 0:58 ` Michael Ellerman
2023-03-07 1:30 ` Baoquan He
2023-03-07 7:17 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d8292ad-c865-4b82-b6e3-d7db75820d0f@app.fastmail.com \
--to=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mcgrof@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).