Linux-m68k Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] treewide: Replace zero-length arrays with flexible-array member
       [not found] <20200211174126.GA29960@embeddedor>
@ 2020-02-12  8:00 ` Geert Uytterhoeven
  2020-02-12  8:36   ` Kars de Jong
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-02-12  8:00 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Linux Kernel Mailing List, Kees Cook, David S. Miller, Greg KH,
	Linux Crypto Mailing List, netdev, USB list, linux-m68k

Hi Gustavo,

On Tue, Feb 11, 2020 at 10:49 PM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
>         int stuff;
>         struct boo array[];
> };
>
> By making use of the mechanism above, we will get a compiler warning
> in case the flexible array does not occur last in the structure, which
> will help us prevent some kind of undefined behavior bugs from being
> unadvertenly introduced[3] to the codebase from now on.
>
> All these instances of code were found with the help of the following
> Coccinelle script:
>
> @@
> identifier S, member, array;
> type T1, T2;
> @@
>
> struct S {
>   ...
>   T1 member;
>   T2 array[
> - 0
>   ];
> };
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> NOTE: I'll carry this in my -next tree for the v5.6 merge window.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Thanks!

> --- a/arch/m68k/tools/amiga/dmesg.c
> +++ b/arch/m68k/tools/amiga/dmesg.c
> @@ -34,7 +34,7 @@ struct savekmsg {
>      u_long magic2;     /* SAVEKMSG_MAGIC2 */
>      u_long magicptr;   /* address of magic1 */
>      u_long size;
> -    char data[0];
> +       char data[];
>  };

JFTR, this file is not really part of the kernel, but supposed to be compiled
by an AmigaOS compiler, which may predate the introduction of support
for flexible array members.

Well, even if you keep it included, I guess the rare users can manage ;-)
My binary dates back to 1996, and I have no plans to recompile it.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] treewide: Replace zero-length arrays with flexible-array member
  2020-02-12  8:00 ` [PATCH] treewide: Replace zero-length arrays with flexible-array member Geert Uytterhoeven
@ 2020-02-12  8:36   ` Kars de Jong
  0 siblings, 0 replies; 2+ messages in thread
From: Kars de Jong @ 2020-02-12  8:36 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Gustavo A. R. Silva, Linux Kernel Mailing List, Kees Cook,
	David S. Miller, Greg KH, Linux Crypto Mailing List, netdev,
	USB list, linux-m68k

Op wo 12 feb. 2020 om 09:00 schreef Geert Uytterhoeven <geert@linux-m68k.org>:
>
> Hi Gustavo,
>
> On Tue, Feb 11, 2020 at 10:49 PM Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
> > --- a/arch/m68k/tools/amiga/dmesg.c
> > +++ b/arch/m68k/tools/amiga/dmesg.c
> > @@ -34,7 +34,7 @@ struct savekmsg {
> >      u_long magic2;     /* SAVEKMSG_MAGIC2 */
> >      u_long magicptr;   /* address of magic1 */
> >      u_long size;
> > -    char data[0];
> > +       char data[];
> >  };
>
> JFTR, this file is not really part of the kernel, but supposed to be compiled
> by an AmigaOS compiler, which may predate the introduction of support
> for flexible array members.

FYI, there's a reasonably modern toolchain for AmigaOS which can
compile this just fine (https://github.com/bebbo/amiga-gcc).

> Well, even if you keep it included, I guess the rare users can manage ;-)
> My binary dates back to 1996, and I have no plans to recompile it.

I did, just to check whether it still worked.

Kind regards,

Kars.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200211174126.GA29960@embeddedor>
2020-02-12  8:00 ` [PATCH] treewide: Replace zero-length arrays with flexible-array member Geert Uytterhoeven
2020-02-12  8:36   ` Kars de Jong

Linux-m68k Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-m68k/0 linux-m68k/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-m68k linux-m68k/ https://lore.kernel.org/linux-m68k \
		linux-m68k@vger.kernel.org linux-m68k@lists.linux-m68k.org
	public-inbox-index linux-m68k

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-m68k


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git