From: Kars de Jong <jongk@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>,
linux-scsi@vger.kernel.org, linux-m68k@vger.kernel.org,
schmitzmic@gmail.com
Subject: Re: [PATCH v3 2/2] esp_scsi: Add support for FSC chip
Date: Mon, 18 Nov 2019 14:27:40 +0100 [thread overview]
Message-ID: <CACz-3rgx4ftrm0JaBq=X13x_3YdcT5zfjcAq0KZtR+hT6CHmow@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.21.1.1911151212001.9@nippy.intranet>
Hi Finn,
Thanks again for the review!
Op vr 15 nov. 2019 om 03:09 schreef Finn Thain <fthain@telegraphics.com.au>:
> On Thu, 14 Nov 2019, Kars de Jong wrote:
>
> > The FSC (NCR53CF9x-2 / SYM53CF9x-2) has a different family code than QLogic
> > or Emulex parts. This caused it to be detected as a FAS100A.
> >
> > Unforunately, this meant the configuration of the CONFIG3 register was
> > incorrect. This causes data transfer issues with FAST-SCSI targets.
> >
> > The FSC also has the CONFIG4 register. It can be used to enable a feature
> > called Active Negation which should always be enabled according to the data
> > manual.
> >
> > Signed-off-by: Kars de Jong <jongk@linux-m68k.org>
>
> Reviewed-by: Finn Thain <fthain@telegraphics.com.au>
>
> This is not the best scope for this variable. You have to touch both lines
> (declaration and initialization) anyway, so you can easily improve this.
Good point, I will move it to inside the "if (esp->rev) == FAST) {" block.
> > - /* Fast 236, AM53c974 or HME */
> > + case FSC:
> > + /* Fast 236, AM53c974, FSC or HME */
>
> This comment merely re-states the logic in the case labels. If you don't
> delete the comment, it has to be maintained along with the case labels.
> Consequently this patch is longer than it needs to be.
Yes, I agree. I'll remove the comment.
>
> You've added "(FSC)" and "(am53c974)" here, which is fine but you've
> repeated yourself in the comment, "found on am53c974 and FSC chips". The
> DRY principle applies here too (Don't Repeat Yourself).
I'll also remove that comment.
> > @@ -264,6 +271,7 @@ enum esp_rev {
> > ESP236,
> > FAS236,
> > PCSCSI, /* AM53c974 */
> > + FSC, /* NCR/Symbios Logic FSC */
>
> Is there a difference between "FSC" and "NCR/Symbios Logic FSC"?
No, the respective data manuals all name these variants as "FSC".
> The reader has to infer that not all "FSC" chips are equivalent and that the
> brand name is significant. Whereas, there is real value in putting a part
> code here (as in the line above).
Agreed, I'll add the part code instead.
Kind regards,
Kars.
next prev parent reply other threads:[~2019-11-18 13:27 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 20:56 Amiga PCMCIA network card support Andreas 'count' Kotes
2019-10-25 7:25 ` Kars de Jong
2019-10-25 11:49 ` Andreas 'count' Kotes
2019-10-28 9:19 ` Kars de Jong
2019-10-28 11:08 ` John Paul Adrian Glaubitz
2019-10-28 13:00 ` Kars de Jong
2019-10-28 13:20 ` John Paul Adrian Glaubitz
2019-10-28 15:39 ` ESP SCSI driver (was: Amiga PCMCIA network card support) Kars de Jong
2019-10-28 18:32 ` Michael Schmitz
2019-10-29 9:37 ` Kars de Jong
2019-10-29 20:20 ` ESP SCSI driver Michael Schmitz
2019-10-29 22:05 ` [PATCH] esp_scsi: Add support for FSC chip Kars de Jong
2019-10-30 0:23 ` Michael Schmitz
2019-10-30 7:11 ` Kars de Jong
2019-10-30 18:42 ` Michael Schmitz
2019-10-30 0:31 ` Finn Thain
2019-10-30 1:06 ` Michael Schmitz
2019-10-30 7:25 ` Kars de Jong
2019-10-30 8:45 ` Geert Uytterhoeven
2019-10-30 9:08 ` Kars de Jong
2019-10-30 18:34 ` Michael Schmitz
2019-10-30 18:52 ` Brad Boyer
2019-10-30 7:22 ` Kars de Jong
2019-10-30 23:15 ` Finn Thain
2019-11-12 18:57 ` [PATCH 0/2] Some esp_scsi updates Kars de Jong
2019-11-12 18:57 ` [PATCH 1/2] esp_scsi: Correct ordering of PCSCSI definition in esp_rev enum Kars de Jong
2019-11-12 23:07 ` Finn Thain
2019-11-13 8:00 ` Kars de Jong
2019-11-13 22:25 ` Finn Thain
2019-11-13 14:22 ` Christoph Hellwig
2019-11-13 15:03 ` Kars de Jong
2019-11-12 18:57 ` [PATCH 2/2] esp_scsi: Add support for FSC chip Kars de Jong
2019-11-12 23:18 ` Finn Thain
2019-11-12 23:57 ` Finn Thain
2019-11-13 9:30 ` Kars de Jong
2019-11-13 22:24 ` Finn Thain
2019-11-14 21:59 ` [PATCH v2 0/2] Some esp_scsi updates Kars de Jong
2019-11-14 21:59 ` [PATCH 1/2] esp_scsi: Correct ordering of PCSCSI definition in esp_rev enum Kars de Jong
2019-11-14 22:06 ` Kars de Jong
2019-11-14 21:59 ` [PATCH 2/2] esp_scsi: Add support for FSC chip Kars de Jong
2019-11-14 22:07 ` Kars de Jong
2019-11-14 22:25 ` [PATCH v3 0/2] Some esp_scsi updates Kars de Jong
2019-11-14 22:25 ` [PATCH v2 1/2] esp_scsi: Correct ordering of PCSCSI definition in esp_rev enum Kars de Jong
2019-11-15 2:13 ` Finn Thain
2019-11-15 7:04 ` Kars de Jong
2019-11-14 22:25 ` [PATCH v3 2/2] esp_scsi: Add support for FSC chip Kars de Jong
2019-11-15 2:09 ` Finn Thain
2019-11-18 13:27 ` Kars de Jong [this message]
2019-11-09 19:14 ` [PATCH] zorro_esp: increase maximum dma length to 65536 bytes Kars de Jong
2019-11-09 20:12 ` James Bottomley
2019-11-10 2:36 ` Michael Schmitz
2019-11-10 9:01 ` Kars de Jong
2019-11-10 19:26 ` Michael Schmitz
2019-11-11 8:47 ` Kars de Jong
2019-11-10 19:35 ` James Bottomley
2019-11-12 17:55 ` [PATCH v2] zorro_esp: Limit DMA transfers to 65536 bytes (except on Fastlane) Kars de Jong
2019-11-12 22:46 ` Finn Thain
2019-11-13 2:27 ` Martin K. Petersen
2019-11-12 9:34 ` [PATCH] zorro_esp: increase maximum dma length to 65536 bytes Kars de Jong
2019-11-09 22:53 ` Finn Thain
2019-11-10 9:06 ` Kars de Jong
2019-10-28 23:38 ` ESP SCSI driver (was: Amiga PCMCIA network card support) Finn Thain
2019-10-29 11:52 ` Kars de Jong
2019-10-29 20:16 ` ESP SCSI driver Michael Schmitz
2019-10-28 22:31 ` Amiga PCMCIA network card support Finn Thain
2019-10-29 8:56 ` FOSDEM (was: Re: Amiga PCMCIA network card support) Geert Uytterhoeven
2019-10-29 9:13 ` John Paul Adrian Glaubitz
2019-10-28 22:08 ` Amiga PCMCIA network card support Finn Thain
2019-10-29 9:00 ` Geert Uytterhoeven
2019-10-29 9:12 ` John Paul Adrian Glaubitz
2019-10-29 9:14 ` Geert Uytterhoeven
2019-10-29 9:20 ` John Paul Adrian Glaubitz
2019-10-29 9:40 ` Kars de Jong
2019-10-28 6:57 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACz-3rgx4ftrm0JaBq=X13x_3YdcT5zfjcAq0KZtR+hT6CHmow@mail.gmail.com' \
--to=jongk@linux-m68k.org \
--cc=fthain@telegraphics.com.au \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).