From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] m68k: virt: generate new RNG seed on reboot
Date: Mon, 26 Sep 2022 12:18:25 +0200 [thread overview]
Message-ID: <CAHmME9oTKp=cw9QFHOU6FKT5qSuQufO5Vo+XPELYGoaQK2fPoA@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWT8dhre5TGjYRnEwn_jCZ6CXxvMpLmKp3KKo_CjPOXRQ@mail.gmail.com>
On 9/26/22, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Jason,
>
> On Fri, Sep 23, 2022 at 7:03 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>> Rather than rebooting into a system with no entropy, regenerate the RNG
>> seed before rebooting, so that the new system has a fresh seed.
>>
>> Fixes: a1ee38ab1a75 ("m68k: virt: Use RNG seed from bootinfo block")
>> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
>
> Thanks for your patch!
>
> I still doubt this is actually guaranteed to work, as the memory containing
> the bootinfo might be overwritten during normal operation.
Thus far, I'm unable to make it *not* work. So this seems like
actually an improvement?
Jason
next prev parent reply other threads:[~2022-09-26 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 17:03 [PATCH v3 1/3] m68k: process bootinfo records before saving them Jason A. Donenfeld
2022-09-23 17:03 ` [PATCH v3 2/3] m68k: virt: generate new RNG seed on reboot Jason A. Donenfeld
2022-09-26 10:10 ` Geert Uytterhoeven
2022-09-26 10:18 ` Jason A. Donenfeld [this message]
2022-09-23 17:03 ` [PATCH v3 3/3] m68k: rework BI_VIRT_RNG_SEED as BI_RNG_SEED Jason A. Donenfeld
2022-09-26 10:27 ` Geert Uytterhoeven
2022-09-26 11:08 ` Jason A. Donenfeld
2022-09-26 11:36 ` Jason A. Donenfeld
2022-09-26 9:57 ` [PATCH v3 1/3] m68k: process bootinfo records before saving them Geert Uytterhoeven
2022-09-26 10:06 ` Jason A. Donenfeld
2022-09-26 10:08 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9oTKp=cw9QFHOU6FKT5qSuQufO5Vo+XPELYGoaQK2fPoA@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).