From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, kexec@lists.infradead.org,
Simon Horman <horms@verge.net.au>,
Laurent Vivier <Laurent@vivier.eu>
Subject: Re: [PATCH kexec-tools] m68k: pass rng seed via BI_VIRT_RNG_SEED
Date: Fri, 23 Sep 2022 18:37:39 +0200 [thread overview]
Message-ID: <CAHmME9ow+ivvQaCnPqRNiYRn4+fuGksKyRAEWtBa-6yhyg9OTA@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdU-KyOXg_nEa=gur-X5vjBimOM+zZ-g-xqYhAV-wBOfSA@mail.gmail.com>
Hi Geert,
On Fri, Sep 23, 2022 at 3:07 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> This won't work as expected: BI_VIRT_* tags are only valid if the
> machine type is MACH_VIRT.
> Worse, this will trigger for other platform-specific tags using the same value:
> Likewise, this will destroy existing BI_AMIGA_CHIPSET and BI_MAC_SCCBASE
> tags, breaking Amiga and Mac.
> As random seeds can now be generic, I think it makes sense to introduce
> a machine-independent BI_RND_SEED.
> In hindsight, we should have done this from the beginning...
Yes, I agree. I thought that would be rejected, though, which is why I
didn't do that before. I'll send a patch switching over to that.
There's no point in keeping the old one around, I don't think, so I'll
just move everything over to the new.
Jason
next prev parent reply other threads:[~2022-09-23 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 12:46 [PATCH kexec-tools] m68k: pass rng seed via BI_VIRT_RNG_SEED Jason A. Donenfeld
2022-09-23 12:53 ` Jason A. Donenfeld
2022-09-23 13:07 ` Geert Uytterhoeven
2022-09-23 16:37 ` Jason A. Donenfeld [this message]
2022-09-23 16:41 ` [PATCH v2] m68k: pass rng seed via BI_RNG_SEED Jason A. Donenfeld
2022-09-28 23:16 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9ow+ivvQaCnPqRNiYRn4+fuGksKyRAEWtBa-6yhyg9OTA@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=Laurent@vivier.eu \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).