From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B97C433E6 for ; Mon, 21 Dec 2020 10:42:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DD8022B2B for ; Mon, 21 Dec 2020 10:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726864AbgLUKln (ORCPT ); Mon, 21 Dec 2020 05:41:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726499AbgLUKln (ORCPT ); Mon, 21 Dec 2020 05:41:43 -0500 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23B54C061282 for ; Mon, 21 Dec 2020 02:41:03 -0800 (PST) Received: by mail-pg1-x532.google.com with SMTP id g18so6122967pgk.1 for ; Mon, 21 Dec 2020 02:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qMI1qb6jm5Lag9GLrKzNd8c/nLzIAunUnseb/Ze4wwk=; b=TNketNi86VoSW7yUCz1xJ0TySRbiCNnk6lgZVPNFHRq1Z0hYh2gKvfrjKM7LrvZdfw RQePP3CI0izt8okVH5i0MDqzLe17kJ+gYsfp1t+Ps8IwCEHGQkv7O3PSU8DKD3ZNNffG /JlM0O2eWxUHvRwz8qee/+LJwONqHO0lDu8V6J4W8M+AzN/jgGfMEfd8saM3jRp+ynNl yyNQ52YpnwxSo70pHdjSzvzY1s3U8IilByiBPR9JecD00QG9hEu5BbgRdRErCXzWs2gF 45fFo4tr95q3qQ6Y+q0mxPqCFls3IDtt7iuwAPe+p0gTlRoSBsbkFCIhsAdHSkhvZ6+r 94Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qMI1qb6jm5Lag9GLrKzNd8c/nLzIAunUnseb/Ze4wwk=; b=QnhIW25GZAM8dbAkPa1FRljWHRY/2cyv3Hc+/DlnDVS4dXOlih/vz82llbwoJpZX/J j+Zm9V71Gxra+PNu+78roP+NqD2XmUaUmKaLyJuFx0DJNl+XdiO1JMkkLIE4aRbvxNLz dy6rk91Zfar64Jjq1p8I6L0VdNiLGapteyoMjDugMfcPZYUbRKB2KXmSk7d0jVTvvjjb 9M8rZvYB7UBCXOfw/iVa+IS0Jovy81JcRvozkrm5WY5IB05dlJ9IjvIPe8glcT7/qKFR Jr72DQi3vxcdgSGfqwA+5VdhHS/zxVWM/m/BxZNG6PAUTecHHCiRcYf5yx8Axz2L+ISj tMGQ== X-Gm-Message-State: AOAM5313uI9RTyqm7LruJ6O+7M/FHLCjD/0eUwU1nO9VDZcTqqEo1Byq 5VH1I2mQja7BsdnTup8s3lBrnmVIXWbnWYJ14FOxQAACUls= X-Google-Smtp-Source: ABdhPJxBtvImbDXQFJZFiuLU9iSSxkb054vusc68KLoVKz7M+YJaEYxx6P2xuo8zwNE89O9MkgEk4eONGxpDIef9SqA= X-Received: by 2002:a63:74b:: with SMTP id 72mr14619803pgh.4.1608542798518; Mon, 21 Dec 2020 01:26:38 -0800 (PST) MIME-Version: 1.0 References: <20201218143122.19459-1-info@metux.net> <20201218143122.19459-2-info@metux.net> <87ft3zyaqa.fsf@mpe.ellerman.id.au> In-Reply-To: <87ft3zyaqa.fsf@mpe.ellerman.id.au> From: Andy Shevchenko Date: Mon, 21 Dec 2020 11:27:27 +0200 Message-ID: Subject: Re: [PATCH 01/23] kernel: irq: irqdescs: warn on spurious IRQ To: Michael Ellerman Cc: "Enrico Weigelt, metux IT consult" , Linux Kernel Mailing List , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Catalin Marinas , Will Deacon , msalter@redhat.com, jacquiot.aurelien@gmail.com, gerg@linux-m68k.org, Geert Uytterhoeven , Thomas Bogendoerfer , James Bottomley , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Yoshinori Sato , Rich Felker , "David S. Miller" , Thomas Gleixner , Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Linus Walleij , Bartosz Golaszewski , Marc Zyngier , Tony Lindgren , Arnd Bergmann , linux-alpha@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , linux-s390@vger.kernel.org, Linux-SH , sparclinux@vger.kernel.org, "open list:GPIO SUBSYSTEM" , Linux OMAP Mailing List , Linux-Arch Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Mon, Dec 21, 2020 at 7:44 AM Michael Ellerman wrote: > Andy Shevchenko writes: > > On Fri, Dec 18, 2020 at 4:37 PM Enrico Weigelt, metux IT consult > > wrote: > > > >> + if (printk_ratelimit()) > >> + pr_warn("spurious IRQ: irq=%d hwirq=%d nr_irqs=%d\n", > >> + irq, hwirq, nr_irqs); > > > > Perhaps you missed pr_warn_ratelimit() macro which is already in the > > kernel for a long time. > > pr_warn_ratelimited() which calls printk_ratelimited(). I stand corrected. Right, that's what I had in mind (actually didn't know that there are variants). Thanks! > And see the comment above printk_ratelimit(): > > /* > * Please don't use printk_ratelimit(), because it shares ratelimiting state > * with all other unrelated printk_ratelimit() callsites. Instead use > * printk_ratelimited() or plain old __ratelimit(). > */ -- With Best Regards, Andy Shevchenko