Linux-m68k Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] i2c: icy: Fix build with CONFIG_AMIGA_PCMCIA=n
@ 2020-06-07 18:28 Max Staudt
  2020-06-07 18:46 ` Wolfram Sang
  0 siblings, 1 reply; 3+ messages in thread
From: Max Staudt @ 2020-06-07 18:28 UTC (permalink / raw)
  To: linux-i2c, wsa+renesas
  Cc: linux-m68k, linux-kernel, glaubitz, Max Staudt, kernel test robot

This has been found by the Kernel Test Robot:
http://lkml.iu.edu/hypermail/linux/kernel/2006.0/06862.html

With CONFIG_AMIGA_PCMCIA=n, io_mm.h does not pull in amigahw.h and
ZTWO_VADDR is undefined. Add forgotten include to i2c-icy.c

Fixes: 4768e90ecaec ("i2c: Add i2c-icy for I2C on m68k/Amiga")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Max Staudt <max@enpas.org>
---
 drivers/i2c/busses/i2c-icy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-icy.c b/drivers/i2c/busses/i2c-icy.c
index 271470f4d..66c9923fc 100644
--- a/drivers/i2c/busses/i2c-icy.c
+++ b/drivers/i2c/busses/i2c-icy.c
@@ -43,6 +43,7 @@
 #include <linux/i2c.h>
 #include <linux/i2c-algo-pcf.h>
 
+#include <asm/amigahw.h>
 #include <asm/amigaints.h>
 #include <linux/zorro.h>
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: icy: Fix build with CONFIG_AMIGA_PCMCIA=n
  2020-06-07 18:28 [PATCH] i2c: icy: Fix build with CONFIG_AMIGA_PCMCIA=n Max Staudt
@ 2020-06-07 18:46 ` Wolfram Sang
  2020-06-13 11:14   ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2020-06-07 18:46 UTC (permalink / raw)
  To: Max Staudt
  Cc: linux-i2c, linux-m68k, linux-kernel, glaubitz, kernel test robot


[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

On Sun, Jun 07, 2020 at 08:28:12PM +0200, Max Staudt wrote:
> This has been found by the Kernel Test Robot:
> http://lkml.iu.edu/hypermail/linux/kernel/2006.0/06862.html
> 
> With CONFIG_AMIGA_PCMCIA=n, io_mm.h does not pull in amigahw.h and
> ZTWO_VADDR is undefined. Add forgotten include to i2c-icy.c
> 
> Fixes: 4768e90ecaec ("i2c: Add i2c-icy for I2C on m68k/Amiga")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Max Staudt <max@enpas.org>

Applied to for-next (i.e. for-5.8), thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: icy: Fix build with CONFIG_AMIGA_PCMCIA=n
  2020-06-07 18:46 ` Wolfram Sang
@ 2020-06-13 11:14   ` Andy Shevchenko
  0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-06-13 11:14 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Max Staudt, linux-i2c, linux-m68k, Linux Kernel Mailing List,
	John Paul Adrian Glaubitz, kernel test robot

On Sun, Jun 7, 2020 at 9:48 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> On Sun, Jun 07, 2020 at 08:28:12PM +0200, Max Staudt wrote:

> Applied to for-next (i.e. for-5.8), thanks!

A bit of offtopic, merge window is at its end, do you have plans to
send PR to Linus soon?

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-07 18:28 [PATCH] i2c: icy: Fix build with CONFIG_AMIGA_PCMCIA=n Max Staudt
2020-06-07 18:46 ` Wolfram Sang
2020-06-13 11:14   ` Andy Shevchenko

Linux-m68k Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-m68k/0 linux-m68k/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-m68k linux-m68k/ https://lore.kernel.org/linux-m68k \
		linux-m68k@vger.kernel.org linux-m68k@lists.linux-m68k.org
	public-inbox-index linux-m68k

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-m68k


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git