From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] binfmt_flat: make load_flat_shared_library() work Date: Wed, 29 May 2019 15:41:31 +0200 Message-ID: References: <20190524201817.16509-1-jannh@google.com> <20190525144304.e2b9475a18a1f78a964c5640@linux-foundation.org> <6956cfe5-90d4-aad4-48e3-66b0ece91fed@linux-m68k.org> <889fc718-b662-8235-5d60-9d330e77cf18@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <889fc718-b662-8235-5d60-9d330e77cf18@linux-m68k.org> Sender: linux-kernel-owner@vger.kernel.org To: Greg Ungerer Cc: Jann Horn , Andrew Morton , Alexander Viro , linux-fsdevel , kernel list , Kees Cook , Nicolas Pitre , Geert Uytterhoeven , Linux/m68k , Russell King , Linux ARM , Sergei Poselenov List-Id: linux-m68k@vger.kernel.org On Wed, May 29, 2019 at 2:29 PM Greg Ungerer wrote: > On 29/5/19 10:05 pm, Arnd Bergmann wrote: > > On Tue, May 28, 2019 at 12:56 PM Greg Ungerer wrote: > >> On 27/5/19 11:38 pm, Jann Horn wrote: > >>> On Sat, May 25, 2019 at 11:43 PM Andrew Morton > >>> wrote: > >>> Maybe... but I didn't want to rip it out without having one of the > >>> maintainers confirm that this really isn't likely to be used anymore. > >> > >> I have not used shared libraries on m68k non-mmu setups for > >> a very long time. At least 10 years I would think. > > > > I think Emcraft have a significant customer base running ARM NOMMU > > Linux, I wonder whether they would have run into this (adding > > Sergei to Cc). > > My suspicion is that they use only binfmt-elf-fdpic, not binfmt-flat. > > > > The only architectures I see that enable binfmt-flat are sh, xtensa > > and h8300, but only arch/sh uses CONFIG_BINFMT_SHARED_FLAT > > m68k uses enables it too. It is the only binary format supported > when running no-mmu on m68k. (You can use it with MMU enabled too > if you really want too). My mistake, I meant to write 'the only architectures /other than m68k/", which you had already mentioned above. Arnd