From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Christoph Hellwig <hch@lst.de>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Guo Ren <guoren@kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
linux-riscv@lists.infradead.org,
Vincent Chen <deanbo422@gmail.com>,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
"open list:QUALCOMM HEXAGON..." <linux-hexagon@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
arcml <linux-snps-arc@lists.infradead.org>,
linux-xtensa@linux-xtensa.org,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Openrisc <openrisc@lists.librecores.org>,
Greentime Hu <green.hu@gmail.com>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Guan Xuetao <gxt@pku.edu.cn>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Michal Simek <monstr@monstr.eu>,
Parisc List <linux-parisc@vger.kernel.org>,
linux-mips@vger.kernel.org, alpha <linux-alpha@vger.kernel.org>,
"moderated list:NIOS2 ARCHITECTURE"
<nios2-dev@lists.rocketboards.org>
Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU
Date: Mon, 11 Nov 2019 11:31:05 +0100 [thread overview]
Message-ID: <CAK8P3a2a7jwmAKhh3WsowCmvdQpsde5A5nz+3NXRn7amhwUxQg@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdVuDp_8UDeWv8tdPAH5JS84=-yfwZjOk-YQcoYKM9za+w@mail.gmail.com>
On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Palmer,
>
> On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt <palmer@dabbelt.com> wrote:
> > It looks like the difference in prototype between the architectures is between
> >
> > void __iomem *ioremap(resource_size_t, size_t)
> > void __iomem *ioremap(phys_addr_t, size_t)
> > void __iomem *ioremap(phys_addr_t, unsigned long)
> > void __iomem *ioremap(unsigned long, unsigned long)
> >
> > shouldn't they all just be that first one? In other words, wouldn't it be
> > better to always provide the generic ioremap prototype and unify the ports
> > instead?
>
> Agreed. But I'd go for the second one.
Right, phys_addr_t is the correct type here, resource_size_t is just a generic
type that is at least as long as any resource, and usually the same as
phys_addr_t, which is supposed to be used for physical addresses.
Arnd
next prev parent reply other threads:[~2019-11-11 10:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191029064834.23438-1-hch@lst.de>
[not found] ` <20191029064834.23438-8-hch@lst.de>
2019-11-05 14:29 ` [PATCH 07/21] parisc: remove __ioremap Helge Deller
[not found] ` <20191029064834.23438-18-hch@lst.de>
2019-11-07 15:29 ` [PATCH 17/21] lib: provide a simple generic ioremap implementation Palmer Dabbelt
2019-11-11 10:10 ` Arnd Bergmann
2019-11-07 20:47 ` generic-iomap tree for linux-next Christoph Hellwig
2019-11-08 2:20 ` Stephen Rothwell
2019-11-08 4:52 ` Stephen Rothwell
2019-11-08 5:14 ` Christoph Hellwig
[not found] ` <20191029064834.23438-11-hch@lst.de>
2019-11-06 17:56 ` [PATCH 10/21] asm-generic: ioremap_uc should behave the same with and without MMU Palmer Dabbelt
2019-11-11 10:09 ` Arnd Bergmann
2019-11-11 10:15 ` Christoph Hellwig
2019-11-11 10:27 ` Arnd Bergmann
2019-11-11 10:29 ` Christoph Hellwig
2019-11-11 19:33 ` Arnd Bergmann
[not found] ` <20191029064834.23438-13-hch@lst.de>
2019-11-07 15:29 ` [PATCH 12/21] arch: rely on asm-generic/io.h for default ioremap_* definitions Palmer Dabbelt
2019-11-11 10:10 ` Arnd Bergmann
[not found] ` <20191029064834.23438-12-hch@lst.de>
2019-11-06 18:11 ` [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU Palmer Dabbelt
2019-11-06 18:16 ` Geert Uytterhoeven
2019-11-06 18:28 ` Christoph Hellwig
2019-11-11 10:31 ` Arnd Bergmann [this message]
2019-11-11 10:29 ` Arnd Bergmann
[not found] ` <20191029064834.23438-2-hch@lst.de>
2019-11-11 10:33 ` [PATCH 01/21] arm: remove ioremap_cached Arnd Bergmann
[not found] ` <20191029064834.23438-4-hch@lst.de>
2019-11-11 10:36 ` [PATCH 03/21] ia64: rename ioremap_nocache to ioremap_uc Arnd Bergmann
[not found] ` <20191029064834.23438-20-hch@lst.de>
2019-11-12 8:51 ` [PATCH 19/21] nds32: use generic ioremap Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2a7jwmAKhh3WsowCmvdQpsde5A5nz+3NXRn7amhwUxQg@mail.gmail.com \
--to=arnd@arndb.de \
--cc=deanbo422@gmail.com \
--cc=geert@linux-m68k.org \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=gxt@pku.edu.cn \
--cc=hch@lst.de \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=monstr@monstr.eu \
--cc=nios2-dev@lists.rocketboards.org \
--cc=openrisc@lists.librecores.org \
--cc=palmer@dabbelt.com \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).