From: Angelo Dureghello <angelo.dureghello@timesys.com>
To: Greg Ungerer <gerg@linux-m68k.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH v6 1/4] m68k: mcf5441x: add support for esdhc mmc controller
Date: Mon, 25 May 2020 10:51:15 +0200 [thread overview]
Message-ID: <CALJHbkAsiFGUD3hWzgd1WqnoMekcC60i6Sn66SZS4nde4ksSdg@mail.gmail.com> (raw)
In-Reply-To: <fdfe557a-49fe-410a-cb05-5bff5e04fdd0@linux-m68k.org>
Hi Greg,
On Mon, May 25, 2020 at 8:02 AM Greg Ungerer <gerg@linux-m68k.org> wrote:
>
> Hi Angelo,
>
> Have you seen this breakage being reported in linux-next?
>
> arch/m68k/coldfire/clk.c:78:60: error: 'MCFSDHC_CLK' undeclared (first
> use in this function); did you mean 'MCF_CLK'?
> arch/m68k/coldfire/clk.c:83:61: error: 'MCFSDHC_CLK' undeclared (first
> use in this function); did you mean 'MCF_CLK'?
> make[2]: *** [scripts/Makefile.build:272: arch/m68k/coldfire/clk.o]
> Error 1
> make[1]: *** [Makefile:1736: arch/m68k/coldfire] Error 2
> make: *** [Makefile:185: __sub-make] Error 2
>
> This is when compiling for pretty much anything other than an mcf5441x
> target.
>
>
> MCFSDHC_CLK will not be defiend for anything other than mcf5441x targets.
>
> This mechanism looks a little out of place here, given how specific
> it is to the sdhc hardware module of the 5441x. Can you move this
> to the m5441x specific code resolving this?
>
i apologize. Couldn't catch that since building for this target.
Fixing, re-testing and sending patch in short.
>
> Regards
> Greg
>
>
Regards,
Angelo
next prev parent reply other threads:[~2020-05-25 8:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 19:17 [PATCH v6 1/4] m68k: mcf5441x: add support for esdhc mmc controller Angelo Dureghello
2020-05-18 19:17 ` [PATCH v6 2/4] mmc: sdhci: add quirks for be to le byte swapping Angelo Dureghello
2020-05-18 19:17 ` [PATCH v6 3/4] mmc: host: add Coldfire esdhc support Angelo Dureghello
2020-05-18 19:17 ` [PATCH v6 4/4] MAINTAINERS: add myself to maintain M5441X mmc host driver Angelo Dureghello
2020-05-19 15:29 ` [PATCH v6 1/4] m68k: mcf5441x: add support for esdhc mmc controller Ulf Hansson
2020-05-19 19:42 ` Angelo Dureghello
2020-05-25 6:02 ` Greg Ungerer
2020-05-25 8:51 ` Angelo Dureghello [this message]
2020-05-25 11:15 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALJHbkAsiFGUD3hWzgd1WqnoMekcC60i6Sn66SZS4nde4ksSdg@mail.gmail.com \
--to=angelo.dureghello@timesys.com \
--cc=adrian.hunter@intel.com \
--cc=gerg@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).