From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E072C63777 for ; Thu, 26 Nov 2020 13:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0D99221F7 for ; Thu, 26 Nov 2020 13:58:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="YGcu1A/b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389961AbgKZN6o (ORCPT ); Thu, 26 Nov 2020 08:58:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389923AbgKZN6o (ORCPT ); Thu, 26 Nov 2020 08:58:44 -0500 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D589EC061A04 for ; Thu, 26 Nov 2020 05:58:42 -0800 (PST) Received: by mail-ej1-x644.google.com with SMTP id jx16so2461564ejb.10 for ; Thu, 26 Nov 2020 05:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0ZnlpdHGKLLs1HjgjZ57oIwQ/E9hSKGuo9TRf/d6l7Y=; b=YGcu1A/bGEojIh2hXNbJIpvpVFABgN62i6zbiwIMkmT7nl5y8yS4N8sQWHV5/pTku5 a/9kwotcQNIUyhtm4NKxkST1Fe+RSzolno64PbsvHvEHvsHnFF1RBeQX46g4gDlyyIjX st/xPIn6drh6b3MpPfMnYnFQJ6RBDxkEFpdg0RBaagKQ6qHnNd9+KmbdrDdLSTI8qJhI /7gn48pxJCmB88DAcKSKghG6NdJVBSjJXeoPOS/6mEg1mMZ1svvletkcVbVKakF6xkiU Laol6REYX5yAcFDzOhSBTiBeRcBQ6VBpO7MXE5nhJkxxdn1wO/7VLGQaE4u7P9IGraCh G3cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0ZnlpdHGKLLs1HjgjZ57oIwQ/E9hSKGuo9TRf/d6l7Y=; b=I8CCmZBNgvXi4IH52oiaNio2rav2MdM0wDk8nDyqXDesrO9Oom9mrB33qfFf9mFlnr rYjLrBacQG7cK/HKcfbe+ztWQVpowJB37xq1vrVQa7aD962C28oZL2Pr3sldo1Oqo/65 F/nFa8nS7L7lxIzU9GqSnrO/Kgy7d4GCzrlk3FnNeA7ViM9bEANlzejgwYwPrPwQB2YJ vrGOqPbv4+nwWowFEk2hcIBXpyWu3jg0TJFWulsgAMng+j0gMe1NKp65sD9z5w/SlYYZ nnygJIuJiwtnWvjQ3TJBufp6PBH3R7hggY5FMLn/vX+Lc7qLLb1Gu03/4kBvjeid3MmC 71gw== X-Gm-Message-State: AOAM532dVUMzdUKeToz+Uw20vP5ntOqIPMRxY4AKaQSaqCJyUx6X6ZrP QLUEonDv38Y2v/B7hI9vjki9TKLTrxVXf3TJnozmVg== X-Google-Smtp-Source: ABdhPJxQ3lbgok2nzajF7J3WM8tj9j7hS/DQ1abTCwysoqXRwAZKsSfY3arkEzD7W3qCTRbOaxjD6QmKApOjXisCCz0= X-Received: by 2002:a17:906:94ca:: with SMTP id d10mr1435532ejy.62.1606399121382; Thu, 26 Nov 2020 05:58:41 -0800 (PST) MIME-Version: 1.0 References: <20201126132952.2287996-1-bigeasy@linutronix.de> <20201126132952.2287996-2-bigeasy@linutronix.de> In-Reply-To: <20201126132952.2287996-2-bigeasy@linutronix.de> From: Jinpu Wang Date: Thu, 26 Nov 2020 14:58:30 +0100 Message-ID: Subject: Re: [PATCH 01/14] scsi: pm80xx: Do not sleep in atomic context. To: Sebastian Andrzej Siewior Cc: Linux SCSI Mailinglist , Finn Thain , GR-QLogic-Storage-Upstream@marvell.com, Hannes Reinecke , John Garry , linux-m68k@lists.linux-m68k.org, Manish Rangankar , Michael Schmitz , MPT-FusionLinux.pdl@broadcom.com, Nilesh Javali , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , Vikram Auradkar , Xiang Chen , Xiaofei Tan , "James E . J . Bottomley" , "Martin K . Petersen" , Thomas Gleixner , "Ahmed S . Darwish" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Thu, Nov 26, 2020 at 2:30 PM Sebastian Andrzej Siewior wrote: > > From: "Ahmed S. Darwish" > > hw_event_sas_phy_up() is used in hardirq/softirq context: > > pm8001_interrupt_handler_msix() || pm8001_interrupt_handler_intx() || pm8001_tasklet > => PM8001_CHIP_DISP->isr() = pm80xx_chip_isr() > => process_oq() [spin_lock_irqsave(&pm8001_ha->lock,)] > => process_one_iomb() > => mpi_hw_event() > => hw_event_sas_phy_up() > => msleep(200) > > Revert the msleep() back to an mdelay() to avoid sleeping in atomic > context. > > Fixes: 4daf1ef3c681 ("scsi: pm80xx: Convert 'long' mdelay to msleep") > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Cc: Vikram Auradkar > Cc: Jack Wang Indeed, thx for the fix. Acked-by: Jack Wang > --- > drivers/scsi/pm8001/pm80xx_hwi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c > index 69f8244539e04..7d838e316657c 100644 > --- a/drivers/scsi/pm8001/pm80xx_hwi.c > +++ b/drivers/scsi/pm8001/pm80xx_hwi.c > @@ -3296,7 +3296,7 @@ hw_event_sas_phy_up(struct pm8001_hba_info *pm8001_ha, void *piomb) > pm8001_get_attached_sas_addr(phy, phy->sas_phy.attached_sas_addr); > spin_unlock_irqrestore(&phy->sas_phy.frame_rcvd_lock, flags); > if (pm8001_ha->flags == PM8001F_RUN_TIME) > - msleep(200);/*delay a moment to wait disk to spinup*/ > + mdelay(200);/*delay a moment to wait disk to spinup*/ > pm8001_bytes_dmaed(pm8001_ha, phy_id); > } > > -- > 2.29.2 >