From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A995C3815B for ; Mon, 20 Apr 2020 07:09:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 071632078E for ; Mon, 20 Apr 2020 07:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726200AbgDTHJL (ORCPT ); Mon, 20 Apr 2020 03:09:11 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:35047 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbgDTHJL (ORCPT ); Mon, 20 Apr 2020 03:09:11 -0400 Received: by mail-oi1-f196.google.com with SMTP id o7so6171030oif.2 for ; Mon, 20 Apr 2020 00:09:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VqzgTPsqGqTG082KlFRd2nLB+TsOjdtbh8/Iv4M7mXY=; b=qhniDweWAhY6Z69GQamBc+i8NLmwdlka7+fSSSGVtg7b4oiqjZglpcgXhEWO9lNRTk ncXUtYrVLjEo4C6TZWBHFJ53VCB/gDwRwClX7SYJYevd3BpfqJfcyLtuR4XcFyKXGoKb xGkPNpqyVFVJOsgfaCMJjyQhG9EylvEyuxEHh16Q8fJsDeatL7UgCFbTAM31EoFmtjW/ Fz3U2lUbtGVHFLtaghihHPfoxPTU+ULmjI4vuPyoctq+NBEtOKRS8JzT3brECgHCFnnF MB6Z+hwtjJusXLwWLIS9YonbT0kD0E2HDDAULEnmULvMkVqY6nbin1mGLs0Aoctk7Tgu kc0g== X-Gm-Message-State: AGi0PubXtJSjzcpRkYVlvYJTZ+mptI0p1InMb6A+ya0YXONq964Fbi/e GuUiGll6K3u2bMZpjepYOWwu5tBA1vFJDutw0+U= X-Google-Smtp-Source: APiQypKGHCQK5p6sv+gc747Hng/rlsT/C7m3rCTyS0eq9olqr91xBNYEDwUpFysdhr4rAeuomxGpe2n/QxOaYd1MVVY= X-Received: by 2002:aca:d50f:: with SMTP id m15mr3273957oig.54.1587366550697; Mon, 20 Apr 2020 00:09:10 -0700 (PDT) MIME-Version: 1.0 References: <20200418070751.25420-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200418070751.25420-1-christophe.jaillet@wanadoo.fr> From: Geert Uytterhoeven Date: Mon, 20 Apr 2020 09:08:58 +0200 Message-ID: Subject: Re: [PATCH] m68k/PCI: Fix a memory leak in an error handling path To: Christophe JAILLET Cc: Greg Ungerer , Bjorn Helgaas , Lorenzo Pieralisi , linux-m68k , Linux Kernel Mailing List , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-m68k-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Sat, Apr 18, 2020 at 9:07 AM Christophe JAILLET wrote: > If 'ioremap' fails, we must free 'bridge', as done in other error handling > path bellow. > > Fixes: 19cc4c843f40 ("m68k/PCI: Replace pci_fixup_irqs() call with host bridge IRQ mapping hooks") > Signed-off-by: Christophe JAILLET Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds