From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F7C3C433E0 for ; Sun, 31 May 2020 08:38:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F281A20707 for ; Sun, 31 May 2020 08:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725991AbgEaIiQ (ORCPT ); Sun, 31 May 2020 04:38:16 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:41840 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725898AbgEaIiQ (ORCPT ); Sun, 31 May 2020 04:38:16 -0400 Received: by mail-ot1-f66.google.com with SMTP id k15so2054184otp.8 for ; Sun, 31 May 2020 01:38:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=il8HCm7VOhnKzl1XMZoe2G47NdOZUu6wpsg1d44qw+4=; b=aXlYR99GQ+9ByT9aUFXPKNpiyFgpByCnP8kBIpeobYmteJGgVkhxdL3jxEuDgOVgkl cARQyOhJufbnkzklucyIA06CFUjOd9ZDKARS9uf79T/bYINzQWlX/lLFd6uhfL47wJrX Tkz6AYiahPbJK+yhUms+eR/X177X+Lh8lXIKJaLDe+tuAj64ePuz3qiyAneMEUYxbyPD KSivvb1peEUvPqyPr9az0JUlpJRujW5ZeL7RLqPd9NSkthxFtae5uijuTPNZUJq4koT+ RIXo4XyLPljqphWQiTx1haMGvRrV17EE15+K5jR3jDMvu57g+eTUKzk14jHqnHREFGCt y6bA== X-Gm-Message-State: AOAM531hiQEnBQodiUjUm6u0AUBFIMeZIsV3eY45/NLEGfiQ89LZQ6DI pMkrELJTIKgvgYjyU3ijXjg9nN61+lAFLJ51ZxY= X-Google-Smtp-Source: ABdhPJyWAqRS0RRmaKRioJgNyQk6X8M+vph3CUcrrUDm59u0OhqrcmYDrag8OKeZfYreJFeDK2DjPdxpkmXZicd+u5A= X-Received: by 2002:a05:6830:141a:: with SMTP id v26mr716939otp.250.1590914295626; Sun, 31 May 2020 01:38:15 -0700 (PDT) MIME-Version: 1.0 References: <0fb7fdcd99d7820bb27faf1f27f7f6f1923914ef.1590880623.git.fthain@telegraphics.com.au> In-Reply-To: <0fb7fdcd99d7820bb27faf1f27f7f6f1923914ef.1590880623.git.fthain@telegraphics.com.au> From: Geert Uytterhoeven Date: Sun, 31 May 2020 10:38:04 +0200 Message-ID: Subject: Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling To: Finn Thain Cc: Benjamin Herrenschmidt , Joshua Thompson , linux-m68k , Linux Kernel Mailing List , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Sender: linux-m68k-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org Hi Finn, On Sun, May 31, 2020 at 1:20 AM Finn Thain wrote: > The adb_driver.autopoll method is needed during ADB bus scan and device > address assignment. Implement this method so that the IOP's list of > device addresses can be updated. When the list is empty, disable SRQ > autopolling. > > Cc: Joshua Thompson > Cc: Geert Uytterhoeven > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Thanks for your patch! Acked-by: Geert Uytterhoeven > arch/m68k/include/asm/adb_iop.h | 1 + > drivers/macintosh/adb-iop.c | 32 ++++++++++++++++++++++++++------ As this header file is used by a single source file only, perhaps it should just be absorbed by the latter? Then you no longer need my Acked-by for future changes ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds