From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2644CA9EDC for ; Tue, 5 Nov 2019 08:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D466820717 for ; Tue, 5 Nov 2019 08:43:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730433AbfKEInC (ORCPT ); Tue, 5 Nov 2019 03:43:02 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:35763 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727401AbfKEInC (ORCPT ); Tue, 5 Nov 2019 03:43:02 -0500 Received: by mail-ot1-f68.google.com with SMTP id z6so16961711otb.2 for ; Tue, 05 Nov 2019 00:43:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p+JwvCyNQZrexeHFulYuJg58ql4mf+z4stztGAEpABo=; b=IEZ5VHaGWpMES1F5+qotL1d9kDAs58blJiI1yIVjSxUyegjXtwkiI/wyT+S4kS4WC5 OnMUcVbCoFGXtaytfN3W78+IDJklXkgzg54I6xQYzhIQSZuerU6qZ4Z1o9ibPElFmTCB m55WDfz9gyoOYFm785800/0t1bPb3IZFb+LCNXgMoaG1rLNd0Q855R54WoBn+8k5kJX5 CzSZarF0mZs+QkTmfHdmizNcvz5e8b+Vu5AHtk8G5l5sGE+CeB5XX1+8WouBTiKlM9ZI fEFSn7PZ0MZemi0GxLO1IwkROSYZkXhzUKTWeMxxuPS8HSH2dpdXv7SZv36ifj7ia6iW 05Kg== X-Gm-Message-State: APjAAAW72nLCdMwPztHa4EMK/fJt/qZlcFMyysGuye/MtvFNt4UVjwnA N5PiAAPhyACGv4J273x2bm3usINRTZJW37YsAeg= X-Google-Smtp-Source: APXvYqx+5QomUWgGs2WmEELvfhS1StbN2l8NrgFKZfoPwalXqUzMRzoyNCmHigrVRNN30YlWOzUuBDvJWTgJHKx2MHg= X-Received: by 2002:a9d:191e:: with SMTP id j30mr12253029ota.297.1572943380002; Tue, 05 Nov 2019 00:43:00 -0800 (PST) MIME-Version: 1.0 References: <20191004132256.GA715053@kroah.com> <20191104193525.229055-1-pterjan@google.com> In-Reply-To: <20191104193525.229055-1-pterjan@google.com> From: Geert Uytterhoeven Date: Tue, 5 Nov 2019 09:42:49 +0100 Message-ID: Subject: Re: [PATCH v3] Remove every trace of SERIAL_MAGIC To: Pascal Terjan Cc: Greg Kroah-Hartman , Jiri Slaby , "open list:SERIAL DRIVERS" , linux-m68k Content-Type: text/plain; charset="UTF-8" Sender: linux-m68k-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org Hi Pascal, On Mon, Nov 4, 2019 at 8:35 PM Pascal Terjan wrote: > This means removing support for some debugging code in amiserial.c > (SERIAL_PARANOIA_CHECK option), which was checking a magic field which > doesn't currently exist in the struct. That code hasn't built at least > since git. > > Removing the definition from the header is safe anyway as that code was > from another driver and not including it. > > Signed-off-by: Pascal Terjan Thanks for your patch! > --- a/drivers/tty/amiserial.c > +++ b/drivers/tty/amiserial.c > @@ -23,17 +23,12 @@ > */ > > /* > - * Serial driver configuration section. Here are the various options: > + * Serial driver configuration section. > * > - * SERIAL_PARANOIA_CHECK > - * Check the magic number for the async_structure where > - * ever possible. > */ You might as well drop the whole comment block, as no options are left. With that fixed: Reviewed-by: Geert Uytterhoeven BTW, there's a similar serial_paranoia_check() in drivers/tty/cyclades.c, which is active, but doesn't serve much purpose, IMHO. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds