linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] m68k - annotate dummy read in Atari ROM port IO code as __maybe_unused
Date: Mon, 29 Jun 2020 20:38:51 +0200	[thread overview]
Message-ID: <CAMuHMdV6v=oMV4WmohYRd+z0N7kMVZq4xcB+KJufuC5xfSc-wA@mail.gmail.com> (raw)
In-Reply-To: <1590878719-21219-1-git-send-email-schmitzmic@gmail.com>

On Sun, May 31, 2020 at 12:45 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> The Atari ROM port IO code uses dummy variables to implement writes
> (not supported by the hardware) as reads that encode the write data
> in part of the address. The value read from the ROM port in this
> operation is discarded.
>
> Annotate dummy variables as __maybe_unused to avoid a compiler warning.

will add "with W=1".

(took me a while to discover, upgraded my cross-compiler in vain ;-)

>
> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
> Reported-by: kbuild test robot <lkp@intel.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v5.9 branch.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2020-06-29 18:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-30 22:45 [PATCH] m68k - annotate dummy read in Atari ROM port IO code as __maybe_unused Michael Schmitz
2020-06-29 18:38 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdV6v=oMV4WmohYRd+z0N7kMVZq4xcB+KJufuC5xfSc-wA@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).