From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF3F9C5DF63 for ; Wed, 6 Nov 2019 18:16:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B923C20663 for ; Wed, 6 Nov 2019 18:16:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732533AbfKFSQu (ORCPT ); Wed, 6 Nov 2019 13:16:50 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:39445 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732522AbfKFSQu (ORCPT ); Wed, 6 Nov 2019 13:16:50 -0500 Received: by mail-ot1-f66.google.com with SMTP id e17so13130142otk.6 for ; Wed, 06 Nov 2019 10:16:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=15BA2o2ULwBaZdW2cSXzi/G8aVSlqB+lkO94w9/s3/8=; b=A041talc2+WAFCuZUznD0tEjK/yz+QSd4WtmfiHt+isxGxAEASERxrxlfr74r0DTIP h8/mipS1AGqQJbPor0hkUPCRD6A8ZQVWuGIK+DUV17K2quq0cXHfYe2g9k1vVuBB5iQ+ NOSjsee9Npx3ms2oRm5C7oDxD/l7I9RSuT54gkgcwQ/0ZaKsJhAf5hECu/A7BSKJtddf MC1/HxoX652UZHx6UUuRjKgoXOYEoT2VY/kJ3NSfSW1ohuYFIsPnWiD2fPBDIXz9LQJU C39M0s1fIicj2g6VNf7qtJDlH0ZiEriU800vk/Bkb2hkB73XvG1rqVxjSxcscBOvrKeK AdAQ== X-Gm-Message-State: APjAAAUVnc7JAxPUqPFXeOj2z1AGbdBruiNmLuBkfQA9JGPP0NqL3Ap7 XMhezsHgQsMMDN2cm8upw/Rs2r5zBCpVEJ/qQSs= X-Google-Smtp-Source: APXvYqyJzH2QJnGyQxa9UcvqsSRwLOqnLR39MniE098RrjM8S3f0LW/gsjuzU8BhMp3pbPwutON3uAZxVc/hg56lCG0= X-Received: by 2002:a9d:191e:: with SMTP id j30mr2894554ota.297.1573064209066; Wed, 06 Nov 2019 10:16:49 -0800 (PST) MIME-Version: 1.0 References: <20191029064834.23438-12-hch@lst.de> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 6 Nov 2019 19:16:38 +0100 Message-ID: Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU To: Palmer Dabbelt Cc: Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , "the arch/x86 maintainers" , arcml , linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-m68k , Openrisc , Greentime Hu , MTD Maling List , Guan Xuetao , Linux ARM , Michal Simek , Parisc List , linux-mips@vger.kernel.org, alpha , nios2-dev@lists.rocketboards.org Content-Type: text/plain; charset="UTF-8" Sender: linux-m68k-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org Hi Palmer, On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > It looks like the difference in prototype between the architectures is between > > void __iomem *ioremap(resource_size_t, size_t) > void __iomem *ioremap(phys_addr_t, size_t) > void __iomem *ioremap(phys_addr_t, unsigned long) > void __iomem *ioremap(unsigned long, unsigned long) > > shouldn't they all just be that first one? In other words, wouldn't it be > better to always provide the generic ioremap prototype and unify the ports > instead? Agreed. But I'd go for the second one. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds