Re: [PATCH v5 2/2] m68k: add kernel seccomp support

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH v5 2/2] m68k: add kernel seccomp support
Date: Mon, 28 Jun 2021 09:18:38 +0200	[thread overview]
Message-ID: <CAMuHMdVvQB_m8dv97wPdfqxouFVgh9Zjrwjn1D0c_7rMK9W_FQ@mail.gmail.com> (raw)
In-Reply-To: <53a462f0-bb89-00fa-76f6-3c615ddf4711@gmail.com>

Hi Michael,

On Fri, Jun 25, 2021 at 11:15 PM Michael Schmitz <schmitzmic@gmail.com> wrote:
> Am 26.06.2021 um 06:42 schrieb Michael Schmitz:
> > Am 25.06.2021 um 19:31 schrieb Geert Uytterhoeven:
> >> On Thu, Jun 24, 2021 at 11:20 PM Michael Schmitz
> >> <schmitzmic@gmail.com> wrote:
> >>> On 23/06/21 7:35 pm, Geert Uytterhoeven wrote:
> >>>> BTW, there was also "[PATCH] [WIP] selftests/seccomp: Add m68k support"
> >>>> https://lore.kernel.org/linux-m68k/alpine.DEB.2.21.2008261315050.25325@ramsan.of.borg/
> >>>>
> >>>>
> >>>> I kept on up-porting it, but haven't exercised it recently.
> >>>
> >>> See attached for test results on my ARAnyM image (Laurent's qemu image,
> >>> essentially).
> >>>
> >>> Is that any different from what you got in your earlier tests?
> >>
> >> Fortunately lore has a better memory than I do ;-)
> >>
> >> https://lore.kernel.org/linux-m68k/alpine.DEB.2.21.2008261612360.2926@ramsan.of.borg/
> >>
> >>
> >> mine: FAILED: 35 / 86 tests passed
> >> yours: FAILED: 35 / 87 tests passed
> >>
> >> So one new test, and it fails?
> >
> > Looks like it. I must be missing some mail in my mail archive, can't
> > recall ever seeing that one.
> >
> > There's one new test added after your mail was sent - KILL_unknown. I
> > suppose it's that one.
> >
> > Anyway, both much better than without seccomp support. And going back
> > over the archive, I found your patch where you added seccomp.h - and
> > added a line in Kbuild as well, which I forgot. Will fix that.
>
> Hmm - after that change, I get:
>
>    SYSHDR  arch/m68k/include/generated/uapi/asm/unistd_32.h
>    SYSTBL  arch/m68k/include/generated/asm/syscall_table.h
>    UPD     include/config/kernel.release
> scripts/Makefile.asm-generic:25: redundant generic-y found in
> arch/m68k/include/asm/Kbuild: seccomp.h
>    WRAP    arch/m68k/include/generated/asm/seccomp.h
>    UPD     include/generated/utsrelease.h
>
> in the build log.
>
> None of the other archs do add seccomp.h to their include/asm/Kbuild
> script. I'll leave it at v6 then.

Indeed, not needed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds