linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>,
	linux-ide@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 2/2] drivers/ata: convert pata_falcon to arch platform device
Date: Mon, 4 Nov 2019 11:31:23 +0100	[thread overview]
Message-ID: <CAMuHMdXSj_mz5cbT3qFykR-ZKVLYvrGYrE=0R2nTKmm2YM=3sw@mail.gmail.com> (raw)
In-Reply-To: <afe0f0bc-21fd-7e09-987b-4b13d2597f91@gmail.com>

Hi Michael,

On Wed, Sep 25, 2019 at 5:59 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> Am 04.09.2019 um 00:44 schrieb Geert Uytterhoeven:
> > On Tue, Jul 2, 2019 at 12:02 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> >> The Atari platform device setup now provides a platform device
> >> for the Falcon IDE interface. Use this in place of the simple platform
> >> device set up in the old pata_falcon probe code.
> >>
> >> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>

> >> +module_platform_driver_probe(pata_falcon_driver, pata_falcon_init_one);
> >
> > This doesn't seem to work in the builtin case (e.g. atari_defconfig with
> > ide replaced by ata): no hard drives are detected.
>
> Due to a dumb naming mismatch between driver and platform code
> (shouldn't have rushed this right before going on leave). This would
> have made the driver fail in the modular case as well.
>
> I'll fix that along with adding some error checking in the Atari
> platform init code.

OK.

> Regarding the potential bisection issue with this series - that ought to
> be fixed as well by renaming the platform resource to match what the new
> driver expects. I'd rather leave the two patches separate so the Atari
> platform code one can go through your tree.

No it isn't: the resource is still busy, and probing fails.
Hence I'll merge them.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

           reply	other threads:[~2019-11-04 10:31 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <afe0f0bc-21fd-7e09-987b-4b13d2597f91@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdXSj_mz5cbT3qFykR-ZKVLYvrGYrE=0R2nTKmm2YM=3sw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schmitzmic@gmail.com \
    --subject='Re: [PATCH 2/2] drivers/ata: convert pata_falcon to arch platform device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).