From: Michael Schmitz <schmitzmic@gmail.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>, linux-ide@vger.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Michael Schmitz <schmitz@debian.org> Subject: Re: [PATCH] ide: falconide: convert to platform driver Date: Wed, 6 Nov 2019 09:02:52 +1300 [thread overview] Message-ID: <CAOmrzk+-FD63N88MTE6993V8-Z96vXpAcB7yd33fftcj3ZebbA@mail.gmail.com> (raw) In-Reply-To: <CAMuHMdVBpMJ6E9N1=YG6VPNJifexdbM9=PWAkjyLwdz9b5n0YQ@mail.gmail.com> Hi Geert, On Wed, Nov 6, 2019 at 7:46 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > > @@ -169,10 +177,21 @@ static int __init falconide_init(void) > > > > Should I remove the __init here? Doesn't hurt in the built-in use > > case, what about use as a module? > > Should be fine. OK, I'll leave it. > > > > > > > err_free: > > > > ide_host_free(host); > > > > err: > > > > - release_mem_region(ATA_HD_BASE, 0x40); > > > > + release_mem_region(res->start, resource_size(res)); > > > > return rc; > > > > } > > > > > > > > -module_init(falconide_init); > > > > +static struct platform_driver ide_falcon_driver = { > > > > + .driver = { > > > > + .name = "atari-falcon-ide", > > > > + }, > > > > +}; > > > > > > Missing .remove() callback. > > > > Can't easily test driver remove, but I can certainly add a callback for that. > > > > ide_unregister does the Right Thing (i.e. leaves the ST-DMA interrupt > > registered) so no reason why it shouldn't work. > > gayle.c uses ide_host_remove(). I'm using that, too. But ide_host_remove() is not where free_irq() is called. > > > > > + > > > > +module_platform_driver_probe(ide_falcon_driver, falconide_init); > > > > + > > > > > > > > +MODULE_AUTHOR("Geert Uytterhoeven"); > > > > +MODULE_DESCRIPTION("low-level driver for Atari Falcon IDE"); > > > > MODULE_LICENSE("GPL"); > > > > +MODULE_ALIAS("platform:atari-falcon-ide"); > > > > +MODULE_VERSION(DRV_VERSION); > > > > > > I'd drop the MODULE_VERSION(). > > > > Done. > > > > Shall I merge this one with part one of the old series so there's no > > chance of a bisection going wrong? > > Yes please. > Thanks! Thanks, I'll send a new version shortly. Cheers, Michael
next prev parent reply other threads:[~2019-11-05 20:03 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1569470064-3977-1-git-send-email-schmitzmic@gmail.com> 2019-10-25 20:33 ` [PATCH RESEND v2 0/2] Convert Atari Falcon IDE driver to platform device Jens Axboe 2019-10-26 18:17 ` Geert Uytterhoeven 2019-10-28 7:03 ` Michael Schmitz 2019-11-04 11:04 ` Geert Uytterhoeven 2019-11-04 19:17 ` Michael Schmitz 2019-11-04 20:06 ` Geert Uytterhoeven 2019-11-04 21:10 ` John Paul Adrian Glaubitz 2019-11-04 21:21 ` Michael Schmitz 2019-11-04 21:42 ` John Paul Adrian Glaubitz 2019-11-05 6:57 ` Michael Schmitz 2019-11-06 1:34 ` Michael Schmitz [not found] ` <1569470064-3977-2-git-send-email-schmitzmic@gmail.com> 2019-11-04 10:56 ` [PATCH RESEND v2 1/2] m68k/atari: add platform device for Falcon IDE port Geert Uytterhoeven 2019-11-04 21:09 ` Michael Schmitz 2019-11-05 6:37 ` [PATCH] ide: falconide: convert to platform driver Michael Schmitz 2019-11-05 8:11 ` Geert Uytterhoeven 2019-11-05 18:31 ` Michael Schmitz 2019-11-05 18:46 ` Geert Uytterhoeven 2019-11-05 20:02 ` Michael Schmitz [this message] 2019-11-05 21:13 ` Michael Schmitz 2019-11-05 21:43 ` Geert Uytterhoeven 2019-11-06 1:35 ` Michael Schmitz 2019-11-05 6:43 ` [PATCH RESEND v2 1/2] m68k/atari: add platform device for Falcon IDE port Michael Schmitz [not found] ` <1569470064-3977-3-git-send-email-schmitzmic@gmail.com> 2019-11-04 10:58 ` [PATCH RESEND v2 2/2] drivers/ata: convert pata_falcon to arch platform device Geert Uytterhoeven 2019-11-06 2:47 ` [PATCH v3] m68k/atari: convert legacy Falcon IDE driver to platform driver Michael Schmitz 2019-11-18 9:20 ` Geert Uytterhoeven 2019-11-18 9:41 ` John Paul Adrian Glaubitz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOmrzk+-FD63N88MTE6993V8-Z96vXpAcB7yd33fftcj3ZebbA@mail.gmail.com \ --to=schmitzmic@gmail.com \ --cc=b.zolnierkie@samsung.com \ --cc=geert@linux-m68k.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-m68k@vger.kernel.org \ --cc=schmitz@debian.org \ --subject='Re: [PATCH] ide: falconide: convert to platform driver' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).