From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E31C4167D for ; Tue, 4 Oct 2022 11:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229971AbiJDLNZ (ORCPT ); Tue, 4 Oct 2022 07:13:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbiJDLNX (ORCPT ); Tue, 4 Oct 2022 07:13:23 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3B5D56BAC for ; Tue, 4 Oct 2022 04:13:19 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id u24so5389391plq.12 for ; Tue, 04 Oct 2022 04:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=UHE2x7YnT+avJBdJRK8fICu4tqbTB0zv1A8Jd5IOhrw=; b=DQ7AqshQw7pAlndMjmyEf3HDNlexUBF+jB73J+4SoV4OjFHAeL9d93Pkb0EJq27wmV fMsaB2Ugk2jANVVFsgCVCwsCPcqfEpNwL8Phil7GBZGqFbBPLY20X/vyyyMA3GQqxwqr 9GitSfUr/lUWnkoEFyKfW1UEPWDsM/lhvI/GgsbbZeTjM/BKXmE2CDDRkoVqqPha6oPu qT7JzbFbc8JYxA1Hnfg8ebCiWushyc4cczI9HWkbShP/pG31SGJukNeZLdU4X/4Dr/J1 nBm7WS/ywrZAsUI2kefDBEEPXrA2HSCWcStoD/F24lMd+RQ2O+RyHYdGsKRKL5ywBm+U IhvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=UHE2x7YnT+avJBdJRK8fICu4tqbTB0zv1A8Jd5IOhrw=; b=N74qHrIQ9xNoEBos/S+qMPRzhI1Rdx5vIf7eJJtSTrLTAYqWGaNLbo1VQOlXXAM9iA v8XhRepY8TSrw+3HylosZlO+U/sk6cIcy40QQX0XjFuQcyuro4iLgvOvTpPQw8hqOrv9 CPvuHMT/LqVcSROxOQFeBBQFqqOvBkmJMoJx15pFq+tsXo0P382AndGh26S8fCQ2efe3 nmxTUAowjO14sG2mC8J30LKv3JxZF8nR4bdYH1kM5l1XcQtsQKe3uVVBSVmKNFREMVm5 Keh2g4rgn6tQfc8AciOSBrF+HpjfMP0MvAjMFX5Pq7xLJL5rkrLezB1dYYzwuA8O9bi8 rcZQ== X-Gm-Message-State: ACrzQf0mN1iGBQ2w6bYUdy0SiUAa9pK7S3nflMDml9jnji2l0f6OcVAt 9EEtxFWE/rihm7SoF1VHvXkkr5UZyEYLGRZIy14P4A== X-Google-Smtp-Source: AMsMyM7BhQDEzGuMq6uijGe+375QPbx+j/BjXkPK0/Xp2Q5WyeWrXvzrh6ljkVul43PLHCDTtENmDZivDluO/kqNLsY= X-Received: by 2002:a17:90b:4d07:b0:1ef:521c:f051 with SMTP id mw7-20020a17090b4d0700b001ef521cf051mr17237644pjb.164.1664881999182; Tue, 04 Oct 2022 04:13:19 -0700 (PDT) MIME-Version: 1.0 References: <20220919095939.761690562@infradead.org> <20220919101522.908560022@infradead.org> In-Reply-To: <20220919101522.908560022@infradead.org> From: Ulf Hansson Date: Tue, 4 Oct 2022 13:12:42 +0200 Message-ID: Subject: Re: [PATCH v2 38/44] cpuidle,powerdomain: Remove trace_.*_rcuidle() To: Peter Zijlstra Cc: juri.lelli@redhat.com, rafael@kernel.org, catalin.marinas@arm.com, linus.walleij@linaro.org, bsegall@google.com, guoren@kernel.org, pavel@ucw.cz, agordeev@linux.ibm.com, linux-arch@vger.kernel.org, vincent.guittot@linaro.org, mpe@ellerman.id.au, chenhuacai@kernel.org, christophe.leroy@csgroup.eu, linux-acpi@vger.kernel.org, agross@kernel.org, geert@linux-m68k.org, linux-imx@nxp.com, vgupta@kernel.org, mattst88@gmail.com, mturquette@baylibre.com, sammy@sammy.net, pmladek@suse.com, linux-pm@vger.kernel.org, Sascha Hauer , linux-um@lists.infradead.org, npiggin@gmail.com, tglx@linutronix.de, linux-omap@vger.kernel.org, dietmar.eggemann@arm.com, andreyknvl@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, senozhatsky@chromium.org, svens@linux.ibm.com, jolsa@kernel.org, tj@kernel.org, Andrew Morton , mark.rutland@arm.com, linux-ia64@vger.kernel.org, dave.hansen@linux.intel.com, virtualization@lists.linux-foundation.org, James.Bottomley@hansenpartnership.com, jcmvbkbc@gmail.com, thierry.reding@gmail.com, kernel@xen0n.name, cl@linux.com, linux-s390@vger.kernel.org, vschneid@redhat.com, john.ogness@linutronix.de, ysato@users.sourceforge.jp, linux-sh@vger.kernel.org, festevam@gmail.com, deller@gmx.de, daniel.lezcano@linaro.org, jonathanh@nvidia.com, dennis@kernel.org, lenb@kernel.org, linux-xtensa@linux-xtensa.org, kernel@pengutronix.de, gor@linux.ibm.com, linux-arm-msm@vger.kernel.org, linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org, loongarch@lists.linux.dev, shorne@gmail.com, chris@zankel.net, sboyd@kernel.org, dinguyen@kernel.org, bristot@redhat.com, alexander.shishkin@linux.intel.com, fweisbec@gmail.com, lpieralisi@kernel.org, atishp@atishpatra.org, linux@rasmusvillemoes.dk, kasan-dev@googlegroups.com, will@kernel.org, boris.ostrovsky@oracle.com, khilman@kernel.org, linux-csky@vger.kernel.org, pv-drivers@vmware.com, linux-snps-arc@lists.infradead.org, mgorman@suse.de, jacob.jun.pan@linux.intel.com, Arnd Bergmann , ulli.kroll@googlemail.com, linux-clk@vger.kernel.org, rostedt@goodmis.org, ink@jurassic.park.msu.ru, bcain@quicinc.com, tsbogend@alpha.franken.de, linux-parisc@vger.kernel.org, ryabinin.a.a@gmail.com, sudeep.holla@arm.com, shawnguo@kernel.org, davem@davemloft.net, dalias@libc.org, tony@atomide.com, amakhalov@vmware.com, konrad.dybcio@somainline.org, bjorn.andersson@linaro.org, glider@google.com, hpa@zytor.com, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, vincenzo.frascino@arm.com, anton.ivanov@cambridgegreys.com, jonas@southpole.se, yury.norov@gmail.com, richard@nod.at, x86@kernel.org, linux@armlinux.org.uk, mingo@redhat.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, richard.henderson@linaro.org, stefan.kristiansson@saunalahti.fi, openrisc@lists.librecores.org, acme@kernel.org, paul.walmsley@sifive.com, linux-tegra@vger.kernel.org, namhyung@kernel.org, andriy.shevchenko@linux.intel.com, jpoimboe@kernel.org, dvyukov@google.com, jgross@suse.com, monstr@monstr.eu, linux-mips@vger.kernel.org, palmer@dabbelt.com, anup@brainfault.org, bp@alien8.de, johannes@sipsolutions.net, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Mon, 19 Sept 2022 at 12:17, Peter Zijlstra wrote: > > OMAP was the one and only user. > > Signed-off-by: Peter Zijlstra (Intel) There are changes to the runtime PM core as part of $subject patch. Perhaps move those parts into a separate patch? In any case, the code looks good to me. Reviewed-by: Ulf Hansson Kind regards Uffe > --- > arch/arm/mach-omap2/powerdomain.c | 10 +++++----- > drivers/base/power/runtime.c | 24 ++++++++++++------------ > 2 files changed, 17 insertions(+), 17 deletions(-) > > --- a/arch/arm/mach-omap2/powerdomain.c > +++ b/arch/arm/mach-omap2/powerdomain.c > @@ -187,9 +187,9 @@ static int _pwrdm_state_switch(struct po > trace_state = (PWRDM_TRACE_STATES_FLAG | > ((next & OMAP_POWERSTATE_MASK) << 8) | > ((prev & OMAP_POWERSTATE_MASK) << 0)); > - trace_power_domain_target_rcuidle(pwrdm->name, > - trace_state, > - raw_smp_processor_id()); > + trace_power_domain_target(pwrdm->name, > + trace_state, > + raw_smp_processor_id()); > } > break; > default: > @@ -541,8 +541,8 @@ int pwrdm_set_next_pwrst(struct powerdom > > if (arch_pwrdm && arch_pwrdm->pwrdm_set_next_pwrst) { > /* Trace the pwrdm desired target state */ > - trace_power_domain_target_rcuidle(pwrdm->name, pwrst, > - raw_smp_processor_id()); > + trace_power_domain_target(pwrdm->name, pwrst, > + raw_smp_processor_id()); > /* Program the pwrdm desired target state */ > ret = arch_pwrdm->pwrdm_set_next_pwrst(pwrdm, pwrst); > } > --- a/drivers/base/power/runtime.c > +++ b/drivers/base/power/runtime.c > @@ -442,7 +442,7 @@ static int rpm_idle(struct device *dev, > int (*callback)(struct device *); > int retval; > > - trace_rpm_idle_rcuidle(dev, rpmflags); > + trace_rpm_idle(dev, rpmflags); > retval = rpm_check_suspend_allowed(dev); > if (retval < 0) > ; /* Conditions are wrong. */ > @@ -481,7 +481,7 @@ static int rpm_idle(struct device *dev, > dev->power.request_pending = true; > queue_work(pm_wq, &dev->power.work); > } > - trace_rpm_return_int_rcuidle(dev, _THIS_IP_, 0); > + trace_rpm_return_int(dev, _THIS_IP_, 0); > return 0; > } > > @@ -493,7 +493,7 @@ static int rpm_idle(struct device *dev, > wake_up_all(&dev->power.wait_queue); > > out: > - trace_rpm_return_int_rcuidle(dev, _THIS_IP_, retval); > + trace_rpm_return_int(dev, _THIS_IP_, retval); > return retval ? retval : rpm_suspend(dev, rpmflags | RPM_AUTO); > } > > @@ -557,7 +557,7 @@ static int rpm_suspend(struct device *de > struct device *parent = NULL; > int retval; > > - trace_rpm_suspend_rcuidle(dev, rpmflags); > + trace_rpm_suspend(dev, rpmflags); > > repeat: > retval = rpm_check_suspend_allowed(dev); > @@ -708,7 +708,7 @@ static int rpm_suspend(struct device *de > } > > out: > - trace_rpm_return_int_rcuidle(dev, _THIS_IP_, retval); > + trace_rpm_return_int(dev, _THIS_IP_, retval); > > return retval; > > @@ -760,7 +760,7 @@ static int rpm_resume(struct device *dev > struct device *parent = NULL; > int retval = 0; > > - trace_rpm_resume_rcuidle(dev, rpmflags); > + trace_rpm_resume(dev, rpmflags); > > repeat: > if (dev->power.runtime_error) { > @@ -925,7 +925,7 @@ static int rpm_resume(struct device *dev > spin_lock_irq(&dev->power.lock); > } > > - trace_rpm_return_int_rcuidle(dev, _THIS_IP_, retval); > + trace_rpm_return_int(dev, _THIS_IP_, retval); > > return retval; > } > @@ -1081,7 +1081,7 @@ int __pm_runtime_idle(struct device *dev > if (retval < 0) { > return retval; > } else if (retval > 0) { > - trace_rpm_usage_rcuidle(dev, rpmflags); > + trace_rpm_usage(dev, rpmflags); > return 0; > } > } > @@ -1119,7 +1119,7 @@ int __pm_runtime_suspend(struct device * > if (retval < 0) { > return retval; > } else if (retval > 0) { > - trace_rpm_usage_rcuidle(dev, rpmflags); > + trace_rpm_usage(dev, rpmflags); > return 0; > } > } > @@ -1202,7 +1202,7 @@ int pm_runtime_get_if_active(struct devi > } else { > retval = atomic_inc_not_zero(&dev->power.usage_count); > } > - trace_rpm_usage_rcuidle(dev, 0); > + trace_rpm_usage(dev, 0); > spin_unlock_irqrestore(&dev->power.lock, flags); > > return retval; > @@ -1566,7 +1566,7 @@ void pm_runtime_allow(struct device *dev > if (ret == 0) > rpm_idle(dev, RPM_AUTO | RPM_ASYNC); > else if (ret > 0) > - trace_rpm_usage_rcuidle(dev, RPM_AUTO | RPM_ASYNC); > + trace_rpm_usage(dev, RPM_AUTO | RPM_ASYNC); > > out: > spin_unlock_irq(&dev->power.lock); > @@ -1635,7 +1635,7 @@ static void update_autosuspend(struct de > atomic_inc(&dev->power.usage_count); > rpm_resume(dev, 0); > } else { > - trace_rpm_usage_rcuidle(dev, 0); > + trace_rpm_usage(dev, 0); > } > } > > > > _______________________________________________ > Virtualization mailing list > Virtualization@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization