From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B457FC433DF for ; Wed, 13 May 2020 22:27:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8A3C2065C for ; Wed, 13 May 2020 22:27:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="qnuaqcZy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731220AbgEMW1A (ORCPT ); Wed, 13 May 2020 18:27:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1731179AbgEMW07 (ORCPT ); Wed, 13 May 2020 18:26:59 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E50D4C05BD0A for ; Wed, 13 May 2020 15:26:58 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id e2so949717eje.13 for ; Wed, 13 May 2020 15:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5gtvWq/MeF/6oEmnw1qXQmZlv3KNk4h6BjoEUKhO/AI=; b=qnuaqcZyt8F/fu6JacXR348SsoSa3Tm7AzZNuvdyRoTov1keyBvQu8pXUwf75HxiOf Kp75KOKoGDVG9AVOlHoBHnEOZ+aGnlYmnNxamZckzNM5gr/kauOLnvq8RbJVSj57g1cw 9NN4htlh7EN6fcqVbepwUivXJDqDlyuHYUdtHPY21wxmzjXy/ZgI5w7jQM2uM22NfFtA q8lS8JkKuJziplyt33amkKJeLTRetS+ezNJTjHtj9SEkChz+0OHqn2TMVceqrJ2eD/4/ 0tsEvnEt2hykkPAkDhJ48WHxBHzBhAZBdTwTt86tywE0BQeuxSyyhNQdkXE9MGPz7xQ5 Snkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5gtvWq/MeF/6oEmnw1qXQmZlv3KNk4h6BjoEUKhO/AI=; b=FsWIAibsIMBQL+/PfNSh9Ywb232yyPzhlM0fKyYHegYRSe7/M2ekro5QwCamtHM0VJ IhDypBZpWyVBKHVhMjlRftExResAAJWFnNKVdLivf5Bwd3rTfnuLVD5tRsb2k2dXwpp6 Hn1a8WaXc6EPlHRJwDUMLg0NQ2Vz6Cr5rO4CZPUR3niTtoQuV/6UM+WAloOmP1/AP16e 5ODZW7AMY/8WczeaMx8nAxoPsGFjRm4T5/3V69hpzEvaByDPyeVOWFeVDUxtWi02/K8d 8OJY3ctTZmaXxSiml9dWvNNlRIvunVrheMadPBBBvCbC0sMVzvZfN2YTxTyqIHqQQk0w GoCA== X-Gm-Message-State: AOAM5314Rh60OeoD1uQ7C58qoFWcfEoCYJh/Kpwr1cl8A6Pwodrzrny/ xxiO5roOaKN/1nybyV3Mm0jl1xmAWSTwHjwjUa6efQ== X-Google-Smtp-Source: ABdhPJz1YkZyiu1OaSAVXpO2AAQnxlh/qNnka1A5+jaiVwuM2r/ADoB+8k1+qusteX+AGprilg7rK2SWSnm96LhSDK4= X-Received: by 2002:a17:906:1f8b:: with SMTP id t11mr1180169ejr.201.1589408817417; Wed, 13 May 2020 15:26:57 -0700 (PDT) MIME-Version: 1.0 References: <20200508161517.252308-1-hch@lst.de> <20200509082352.GB21834@lst.de> <20200512080820.GA2336@lst.de> In-Reply-To: <20200512080820.GA2336@lst.de> From: Dan Williams Date: Wed, 13 May 2020 15:26:45 -0700 Message-ID: Subject: Re: remove a few uses of ->queuedata To: Christoph Hellwig Cc: Jens Axboe , Jim Paris , Geoff Levand , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-m68k@lists.linux-m68k.org, Linux Kernel Mailing List , linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linuxppc-dev , linux-bcache@vger.kernel.org, linux-raid , linux-nvdimm Content-Type: text/plain; charset="UTF-8" Sender: linux-m68k-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Tue, May 12, 2020 at 1:08 AM Christoph Hellwig wrote: > > On Sat, May 09, 2020 at 08:07:14AM -0700, Dan Williams wrote: > > > which are all used in the I/O submission path (generic_make_request / > > > generic_make_request_checks). This is mostly a prep cleanup patch to > > > also remove the pointless queue argument from ->make_request - then > > > ->queue is an extra dereference and extra churn. > > > > Ah ok. If the changelogs had been filled in with something like "In > > preparation for removing @q from make_request_fn, stop using > > ->queuedata", I probably wouldn't have looked twice. > > > > For the nvdimm/ driver updates you can add: > > > > Reviewed-by: Dan Williams > > > > ...or just let me know if you want me to pick those up through the nvdimm tree. > > I'd love you to pick them up through the nvdimm tree. Do you want > to fix up the commit message yourself? Will do, thanks.