From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
Michael Schmitz <schmitzmic@gmail.com>
Subject: Re: [PATCH] m68k: mac: Reword comment using double "in"
Date: Fri, 28 Oct 2022 20:01:01 +0700 [thread overview]
Message-ID: <Y1vSjQfkDfPINUBo@debian.me> (raw)
In-Reply-To: <0229879ee3e2d8828707d291cddbb89ac18a10c2.1666945731.git.geert@linux-m68k.org>
[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]
On Fri, Oct 28, 2022 at 10:30:26AM +0200, Geert Uytterhoeven wrote:
> People keep on sending (incorrect) patches to remove the second
> occurrence of the word "in". Reword the comment to stop the inflood.
>
Ah! People who aren't fluent in English think that duplicated "in" below
isn't OK, which after stripping that become nonsense without reading the
actual code.
> Suggested-by: Michael Schmitz <schmitzmic@gmail.com>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> To be queued in the m68k branch for v6.2.
Should this patch be Cc: stable'ed so that no more trivial patches as
you mentioned?
>
> arch/m68k/mac/misc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c
> index 4fab3479175865d4..c7cb29f0ff016360 100644
> --- a/arch/m68k/mac/misc.c
> +++ b/arch/m68k/mac/misc.c
> @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)
>
> reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);
>
> - /* The bits of the byte go in in MSB order */
> + /* The bits of the byte go into the RTC in MSB order */
>
LGTM, thanks.
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-10-28 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 8:30 [PATCH] m68k: mac: Reword comment using double "in" Geert Uytterhoeven
2022-10-28 13:01 ` Bagas Sanjaya [this message]
2022-10-28 13:04 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1vSjQfkDfPINUBo@debian.me \
--to=bagasdotme@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).