From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54290C433ED for ; Tue, 11 May 2021 10:36:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 225FE615FF for ; Tue, 11 May 2021 10:36:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229955AbhEKKh5 (ORCPT ); Tue, 11 May 2021 06:37:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229892AbhEKKh4 (ORCPT ); Tue, 11 May 2021 06:37:56 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49846C061761 for ; Tue, 11 May 2021 03:36:50 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id r5so10731461lfr.5 for ; Tue, 11 May 2021 03:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mPTGhSdYS1EwXktDTrRYGbw3xN/gpinHXJ0dbeYJ3es=; b=uLAisls4ltrVE4/Ogyxj6kPvgrmoXy2pwMhFXj+C/1mOobjpzx0EP8xJNpPURz4OnO aG3Dll4zNPrlWeqY0JdN4+eQlLJTqkmso/8DyY9YVmessQPzyJGx/DXBAEwNcJv4I27Q dg3nz34jHrmu6DbuXxwJVHRD0x+uCOGhKYluvrALG/nIBDwCUIJj+kta9gu9WH3LwJe/ 6S4Ak774b1i9g7BRjnIg41lyA7bGEuj7lcaAlvpjpXPArfdeOpBG1SBXs9nJhirvfFT4 o1JWaFsxWH/O4AHF7N+q/aFWJ3nib2f/V8tR/oKhB8oiytYd2RPUHCqGVg+W7jV8oYac tfxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mPTGhSdYS1EwXktDTrRYGbw3xN/gpinHXJ0dbeYJ3es=; b=PAy8jPpzEri+QdM5h9iYGcDwPP3bh/1d3qEyFtiwepizf782+meAQSqzMnbKNr2F6s EnIswzGx76V9jkA1PrDyW3WChrdKRPM6vwFzPuEBxa1HWY/Sdr8xjTLUv7LIUUAwD83Z IwqgoB7/ZRvYbzJFVjvPjwX3LcxFDMAQHr+DL6Or5gdgZOcxE5TSiWxSqpTSuUNHZnRN rLrv2X+UCE32UBuGfNVo0B+nocRrYudeDYvYZa4ep7Jmqdvyw079bI+oNn+AK+PiBcMN Qra36geetnakQvaod/nPVrMicwoSsAJENX7j0tEnYRxA3TUAKXjYmssMtx2SFsEQdBPb M8yQ== X-Gm-Message-State: AOAM533PchgG5jz+xlPdLOzjjXIog0g7EON6qhM+5tm1jN7vqz4fhPed rYbFjYHmNJJK3Rcw91J9oL4= X-Google-Smtp-Source: ABdhPJxH3TGCNCqhpUbtkmWcuM1loUXzrtKYaQ4Uv96NT1vQ/n7AYKCj9cmK9h40us2sMTkRMZ1b/Q== X-Received: by 2002:a19:c111:: with SMTP id r17mr19841633lff.564.1620729408667; Tue, 11 May 2021 03:36:48 -0700 (PDT) Received: from rikard (h-158-174-22-223.NA.cust.bahnhof.se. [158.174.22.223]) by smtp.gmail.com with ESMTPSA id n7sm2548891lft.65.2021.05.11.03.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 03:36:48 -0700 (PDT) From: Rikard Falkeborn X-Google-Original-From: Rikard Falkeborn Date: Tue, 11 May 2021 12:36:44 +0200 To: Andy Shevchenko Cc: Rikard Falkeborn , Tetsuo Handa , Yury Norov , Linux Kernel Mailing List , Andrew Morton , Rasmus Villemoes , linux-m68k , Linux-Arch , Linux-SH , Alexey Klimov , Arnd Bergmann , David Sterba , Dennis Zhou , Geert Uytterhoeven , Jianpeng Ma , Joe Perches , John Paul Adrian Glaubitz , Josh Poimboeuf , Rich Felker , Stefano Brivio , Wei Yang , Wolfram Sang , Yoshinori Sato Subject: Re: [PATCH 11/12] tools: sync lib/find_bit implementation Message-ID: References: <20210401003153.97325-1-yury.norov@gmail.com> <20210401003153.97325-12-yury.norov@gmail.com> <1ac7bbc2-45d9-26ed-0b33-bf382b8d858b@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Tue, May 11, 2021 at 10:28:50AM +0300, Andy Shevchenko wrote: > On Tue, May 11, 2021 at 12:51:58AM +0200, Rikard Falkeborn wrote: > > On Mon, May 10, 2021 at 06:44:44PM +0300, Andy Shevchenko wrote: > > ... > > > Does the following work for you? For simplicity, I copied__is_constexpr from > > include/linux/minmax.h (which isn't available in tools/). A proper patch > > would reuse __is_constexpr (possibly refactoring it to a separate > > header since bits.h including minmax.h for that only seems smelly) > > I think we need to have it in something like compiler.h (top level). Under > 'top level' I meant something with the function as of compiler.h but with > Linuxisms rather than compiler attributes or so. Right. Will you send a patch, or do you want me to? It would be good to get confirmation that __is_constexpr solves the build failure. > > Separate header for the (single) macro is too much... > Agreed. > > and fix > > bits.h in the kernel header as well, to keep the files in sync. > > Right. > > -- > With Best Regards, > Andy Shevchenko > > With Best Regards, Rikard