* [PATCH] m68k/nommu: prevent setting ROMKERNEL when ROM is not set
@ 2021-07-07 16:37 Randy Dunlap
2021-07-08 12:33 ` Greg Ungerer
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-07-07 16:37 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Greg Ungerer, linux-m68k, uclinux-dev
When CONFIG_ROMKERNEL is set but CONFIG_ROM is not set, the linker
complains:
m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:5: undefined symbol `CONFIG_ROMSTART' referenced in expression
# CONFIG_ROM is not set
# CONFIG_RAMKERNEL is not set
CONFIG_ROMKERNEL=y
Since ROMSTART depends on ROM, make ROMKERNEL also depend on ROM.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Greg Ungerer <gerg@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Cc: uclinux-dev@uclinux.org
---
arch/m68k/Kconfig.machine | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210701.orig/arch/m68k/Kconfig.machine
+++ linux-next-20210701/arch/m68k/Kconfig.machine
@@ -464,6 +464,7 @@ config RAMKERNEL
config ROMKERNEL
bool "ROM"
+ depends on ROM
help
The kernel will be resident in FLASH/ROM when running. This is
often referred to as Execute-in-Place (XIP), since the kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] m68k/nommu: prevent setting ROMKERNEL when ROM is not set
2021-07-07 16:37 [PATCH] m68k/nommu: prevent setting ROMKERNEL when ROM is not set Randy Dunlap
@ 2021-07-08 12:33 ` Greg Ungerer
0 siblings, 0 replies; 2+ messages in thread
From: Greg Ungerer @ 2021-07-08 12:33 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel; +Cc: linux-m68k, uclinux-dev
Hi Randy,
On 8/7/21 2:37 am, Randy Dunlap wrote:
> When CONFIG_ROMKERNEL is set but CONFIG_ROM is not set, the linker
> complains:
> m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:5: undefined symbol `CONFIG_ROMSTART' referenced in expression
>
> # CONFIG_ROM is not set
> # CONFIG_RAMKERNEL is not set
> CONFIG_ROMKERNEL=y
>
> Since ROMSTART depends on ROM, make ROMKERNEL also depend on ROM.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Greg Ungerer <gerg@linux-m68k.org>
> Cc: linux-m68k@lists.linux-m68k.org
> Cc: uclinux-dev@uclinux.org
Looks good, thanks.
I will apply to for-next branch of m68knommu git tree when the current
merge window closes.
Regards
Greg
> ---
> arch/m68k/Kconfig.machine | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210701.orig/arch/m68k/Kconfig.machine
> +++ linux-next-20210701/arch/m68k/Kconfig.machine
> @@ -464,6 +464,7 @@ config RAMKERNEL
>
> config ROMKERNEL
> bool "ROM"
> + depends on ROM
> help
> The kernel will be resident in FLASH/ROM when running. This is
> often referred to as Execute-in-Place (XIP), since the kernel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-08 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-07 16:37 [PATCH] m68k/nommu: prevent setting ROMKERNEL when ROM is not set Randy Dunlap
2021-07-08 12:33 ` Greg Ungerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).