From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53BD7C4332F for ; Thu, 10 Nov 2022 17:59:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229982AbiKJR7J (ORCPT ); Thu, 10 Nov 2022 12:59:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbiKJR7I (ORCPT ); Thu, 10 Nov 2022 12:59:08 -0500 X-Greylist: delayed 536 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 10 Nov 2022 09:59:05 PST Received: from welho-filter3.welho.com (welho-filter3b.welho.com [83.102.41.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9166745A15 for ; Thu, 10 Nov 2022 09:59:05 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by welho-filter3.welho.com (Postfix) with ESMTP id 7499113599; Thu, 10 Nov 2022 19:50:07 +0200 (EET) X-Virus-Scanned: Debian amavisd-new at pp.htv.fi Received: from welho-smtp1.welho.com ([IPv6:::ffff:83.102.41.84]) by localhost (welho-filter3.welho.com [::ffff:83.102.41.25]) (amavisd-new, port 10024) with ESMTP id taeA9fSntBK7; Thu, 10 Nov 2022 19:50:07 +0200 (EET) Received: from [192.168.0.20] (82-181-37-202.bb.dnainternet.fi [82.181.37.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by welho-smtp1.welho.com (Postfix) with ESMTPSA id 142A27A; Thu, 10 Nov 2022 19:50:05 +0200 (EET) Message-ID: Date: Thu, 10 Nov 2022 19:50:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH printk v3 24/40] tty: nfcon: use console_is_registered() Content-Language: en-US References: <20221107141638.3790965-1-john.ogness@linutronix.de> <20221107141638.3790965-25-john.ogness@linutronix.de> <87cz9u6gfd.fsf@jogness.linutronix.de> From: Eero Tamminen To: linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org In-Reply-To: <87cz9u6gfd.fsf@jogness.linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org Hi, On 10.11.2022 16.19, John Ogness wrote: > On 2022-11-10, Petr Mladek wrote: ... >>> @@ -106,10 +106,8 @@ static int __init nf_debug_setup(char *arg) >>> return 0; >>> >>> stderr_id = nf_get_id("NF_STDERR"); >>> - if (stderr_id) { >>> - nf_console.flags |= CON_ENABLED; >>> + if (stderr_id) >>> register_console(&nf_console); >> >> My understanding is that this should enable the console >> when debug=nfcon kernel parameter is used. >> >> It is a non-standard way. This is why CON_ENABLED flag >> has to be explicitly set. > > Understood. I will add a comment explaining why CON_ENABLED is set here. NatFeats is emulator feature. If you want to test the resulting kernel, you can use either Aranym or Hatari emulator. Aranym NF docs are here: https://github.com/aranym/aranym/wiki/natfeats-proposal Hatari m68k linux docs are here: https://hatari.tuxfamily.org/doc/m68k-linux.txt - Eero