From: Max Staudt <max@enpas.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-ide@vger.kernel.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Michael Schmitz <schmitzmic@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v2] ata/pata_buddha: Probe via modalias instead of initcall
Date: Thu, 25 Jul 2019 19:33:44 +0200 [thread overview]
Message-ID: <a81d7a5f-c773-9769-cddd-95d2fe47d32e@enpas.org> (raw)
In-Reply-To: <01cfe282-6ce6-ff40-9e85-e23724f9d50f@samsung.com>
On 07/25/2019 07:03 PM, Bartlomiej Zolnierkiewicz wrote:
>> +err_ata_host_alloc:
>> + switch (type) {
>> + case BOARD_BUDDHA:
>> + case BOARD_CATWEASEL:
>> + default:
>> + devm_release_mem_region(&z->dev,
>> + board + BUDDHA_BASE1,
>> + 0x800);
>
> Could you please explain why this is needed now?
>
> [ The whole idea of using devm_* helpers is to not have to release
> resources explicitly. ]
My mistake. Thanks, I'll fix it.
>> +static void pata_buddha_remove(struct zorro_dev *zdev)
>> +{
>> + /* NOT IMPLEMENTED */
>> +
>> + WARN_ONCE(1, "pata_buddha: Attempted to remove driver. This is not implemented yet.\n");
>
> Please try to implement it, should be as simple as:
>
> static void pata_buddha_remove(struct zorro_dev *zdev)
> {
> struct ata_host *host = dev_get_drvdata(&zdev->dev);
>
> ata_host_detach(host);
> }
>
> [ ata_host_alloc() in pata_buddha_probe() sets drvdata to host ]
Seeing as the driver is almost 1:1 the same as pata_gayle, I see no reason against this.
Do you need me to test module removal on the real machine, or is it okay to take your suggestion as-is, given that it is already accepted in pata_gayle?
> The rest of the patch looks fine, thanks for working on this driver.
Thanks for reviewing it, and thanks for porting buddha to libata!
> PS Next time please also use scripts/get_maintainer.pl script to get
> the list of people that should be added to Cc:, i.e.:
>
> $ ./scripts/get_maintainer.pl -f drivers/ata/pata_buddha.c
> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> (maintainer:LIBATA PATA DRIVERS)
> Jens Axboe <axboe@kernel.dk> (maintainer:LIBATA PATA DRIVERS)
> linux-ide@vger.kernel.org (open list:LIBATA PATA DRIVERS)
> linux-kernel@vger.kernel.org (open list)
>
> [ I've also added John, Michael & Geert to Cc: (as they were all
> involved in the development of the initial driver version). ]
Oops, thanks for fixing this.
Max
next prev parent reply other threads:[~2019-07-25 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 10:22 [PATCH v2] ata/pata_buddha: Probe via modalias instead of initcall Max Staudt
[not found] ` <CGME20190725170359eucas1p271187268f749869088f60bf961194169@eucas1p2.samsung.com>
2019-07-25 17:03 ` Bartlomiej Zolnierkiewicz
2019-07-25 17:33 ` Max Staudt [this message]
2019-07-25 17:59 ` Max Staudt
2019-07-25 18:01 ` John Paul Adrian Glaubitz
2019-07-29 8:53 ` Geert Uytterhoeven
2019-07-29 10:49 ` Max
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a81d7a5f-c773-9769-cddd-95d2fe47d32e@enpas.org \
--to=max@enpas.org \
--cc=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).