From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 450F2C7EE23 for ; Tue, 16 May 2023 00:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343537AbjEPAxw (ORCPT ); Mon, 15 May 2023 20:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245504AbjEPAxu (ORCPT ); Mon, 15 May 2023 20:53:50 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CEB7BBC for ; Mon, 15 May 2023 17:53:49 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 9D7EE92009C; Tue, 16 May 2023 02:53:45 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 9709492009B; Tue, 16 May 2023 01:53:45 +0100 (BST) Date: Tue, 16 May 2023 01:53:45 +0100 (BST) From: "Maciej W. Rozycki" To: Alexandre Ghiti cc: Greg KH , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Chris Zankel , Max Filippov , Arnd Bergmann , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org, Palmer Dabbelt Subject: Re: [PATCH v5 14/26] alpha: Remove empty In-Reply-To: <20230306100508.1171812-15-alexghiti@rivosinc.com> Message-ID: References: <20230306100508.1171812-1-alexghiti@rivosinc.com> <20230306100508.1171812-15-alexghiti@rivosinc.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Mon, 6 Mar 2023, Alexandre Ghiti wrote: > diff --git a/arch/alpha/include/uapi/asm/setup.h b/arch/alpha/include/uapi/asm/setup.h > deleted file mode 100644 > index 9b3b5ba39b1d..000000000000 > --- a/arch/alpha/include/uapi/asm/setup.h > +++ /dev/null > @@ -1,5 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > -#ifndef _UAPI__ALPHA_SETUP_H > -#define _UAPI__ALPHA_SETUP_H > - > -#endif /* _UAPI__ALPHA_SETUP_H */ You can't just remove a UAPI header like this, something will break; cf. arch/arc/include/uapi/asm/setup.h, or arch/x86/include/uapi/asm/setup.h if you want it brief. I suggest that you fold it into 01/26 (it makes no sense to have empty multiple inclusion protection), and likewise for the relevant remaining headers. Maciej