From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905B0C433E0 for ; Mon, 1 Jun 2020 00:05:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 640A1206C3 for ; Mon, 1 Jun 2020 00:05:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728445AbgFAAFJ (ORCPT ); Sun, 31 May 2020 20:05:09 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:52112 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbgFAAFJ (ORCPT ); Sun, 31 May 2020 20:05:09 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 8810C28F67; Sun, 31 May 2020 20:05:06 -0400 (EDT) Date: Mon, 1 Jun 2020 10:05:05 +1000 (AEST) From: Finn Thain To: Geert Uytterhoeven cc: Joshua Thompson , linux-m68k , Linux Kernel Mailing List Subject: Re: [PATCH 0/4] Mac IOP driver fixes In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-m68k-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Sun, 31 May 2020, Geert Uytterhoeven wrote: > Hi Finn, > > On Sun, May 31, 2020 at 1:16 AM Finn Thain wrote: > > > This patch series has several bug fixes for the IOP driver and some > > improvements to the debug level log messages. > > Thanks for your series! > Thanks for your review and for your diligence in the performance of all of your duties as maintainer. > > Geert, please consider pushing these fixes for v5.8, if not the whole > > series. > > I'm afraid it's a bit too late for that, as I expect the v5.8 merge > window to open tonight. Well, it's not that important. > Unless the fix is for a regression in v5.7. AFAICT these bugs are as old as the original driver. But I don't think that disqualifies them from backporting, which I plan to do that once they hit mainline. > BTW, how does the issue being fixed manifest itself? That's not clear to > me from the patch description. > The bugs in the iop driver were found by inspection, in the course of debugging adb-iop driver failures that Stan encountered. It's possible that the adb-iop driver is not badly affected by these bugs (I don't know). It's possible that the iop driver bugs are among the reasons why the swim_iop driver was never stabilized. That driver was removed in b21a323710e7 ("[PATCH] remove the broken BLK_DEV_SWIM_IOP driver").