Re: [PATCH 1/5] can: flexcan: add platform data for ColdFire

[Angelo Dureghello <angelo@kernel-space.org>]

Hi Joakim,

On 09/06/21 4:05 AM, Joakim Zhang wrote:
> 
>> -----Original Message-----
>> From: Angelo Dureghello <angelo@kernel-space.org>
>> Sent: 2021年6月9日 4:46
>> To: gerg@linux-m68k.org; wg@grandegger.com; mkl@pengutronix.de
>> Cc: geert@linux-m68k.org; linux-m68k@vger.kernel.org;
>> linux-can@vger.kernel.org; Joakim Zhang <qiangqing.zhang@nxp.com>;
>> Angelo Dureghello <angelo@kernel-space.org>
>> Subject: [PATCH 1/5] can: flexcan: add platform data for ColdFire
>>
>> Add platform data object for ColdFire architecture.
>>
>> Signed-off-by: Angelo Dureghello <angelo@kernel-space.org>
>> ---
>>   include/linux/platform_data/flexcan-mcf.h | 27 +++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>>   create mode 100644 include/linux/platform_data/flexcan-mcf.h
>>
>> diff --git a/include/linux/platform_data/flexcan-mcf.h
>> b/include/linux/platform_data/flexcan-mcf.h
>> new file mode 100644
>> index 000000000000..71fe1a9df084
>> --- /dev/null
>> +++ b/include/linux/platform_data/flexcan-mcf.h
> 
> Should locate CAN header file here? include/linux/can/platform/
> 

oh, missed that place, looks like that location is more correct,
sure, can move the file there.

> Best Regards,
> Joakim Zhang
>> @@ -0,0 +1,27 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/*
>> + * Flexcan options for ColdFire family
>> + *
>> + * Copyright (C) 2021  Angelo Dureghello <angelo@kernel-space.org>
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License
>> + * version 2 as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +#ifndef _PLAT_FLEXCAN_MCF_H
>> +#define _PLAT_FLEXCAN_MCF_H
>> +
>> +struct mcf_flexcan_platform_data {
>> +	int stop_mode;
>> +	int clk_src;
>> +	int clock_frequency;
>> +	bool big_endian;
>> +};
>> +
>> +#endif /* _PLAT_FLEXCAN_MCF_H */
>> --
>> 2.31.1
> 

Regards
-- 
Angelo Dureghello
+++ kernelspace +++
+E: angelo AT kernel-space.org
+W: www.kernel-space.org