linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Finn Thain <fthain@linux-m68k.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@infradead.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"David S. Miller" <davem@davemloft.net>,
	Joshua Thompson <funaho@jurai.org>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	Richard Zidlicky <rz@linux-m68k.org>
Subject: Re: [PATCH v2 0/2] Use libata platform drivers to replace deprecated m68k IDE drivers
Date: Wed, 9 Jun 2021 16:05:50 +1200	[thread overview]
Message-ID: <e1099cb5-c83f-d259-d16d-c07e3a3dcdc1@gmail.com> (raw)
In-Reply-To: <1016d48a-a276-f7b0-49a8-4571f4f75a61@linux-m68k.org>

Hi Finn,

Am 09.06.2021 um 15:53 schrieb Finn Thain:
> On Wed, 9 Jun 2021, Michael Schmitz wrote:
>
>> please note that Finn's patch depends on one of mine currently under review.
>> Without that one, Q40 support may break in certain cases.
>>
>
> AFAIK, that's only true for a configuration that enables both CONFIG_Q40
> and CONFIG_ATARI. In my tests with stock v5.12, such a configuration
> presently doesn't work correctly on Atari.
>
> This patch series doesn't make this issue any worse.

You're right, it's not a regression (that combination was broken before) 
, and there's no patch dependency or conflict either.

> Besides, I think it is a non-issue because the problem is so rare that
> no-one noticed it before I did, and the workaround for CONFIG_Q40 users is
> trivial anyway (disable CONFIG_ATARI).
>
> Is there really some benefit in holding up this patch series?

On second thought - no point in holding this up.

Cheers,

	Michael



  reply	other threads:[~2021-06-09  4:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  5:46 [PATCH v2 0/2] Use libata platform drivers to replace deprecated m68k IDE drivers Finn Thain
2021-06-08  5:46 ` [PATCH v2 2/2] m68k/q40: Replace q40ide driver with pata_falcon and falconide Finn Thain
2021-06-09  6:30   ` Geert Uytterhoeven
2021-06-08  5:46 ` [PATCH v2 1/2] m68k/mac: Replace macide driver with generic platform drivers Finn Thain
2021-06-09  6:26   ` Geert Uytterhoeven
2021-06-08 14:37 ` [PATCH v2 0/2] Use libata platform drivers to replace deprecated m68k IDE drivers Christoph Hellwig
2021-06-08 21:04   ` Jens Axboe
2021-06-08 21:50     ` Michael Schmitz
2021-06-09  3:53       ` Finn Thain
2021-06-09  4:05         ` Michael Schmitz [this message]
2021-06-09 15:23       ` Jens Axboe
2021-06-09 19:26         ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1099cb5-c83f-d259-d16d-c07e3a3dcdc1@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=fthain@linux-m68k.org \
    --cc=funaho@jurai.org \
    --cc=geert@linux-m68k.org \
    --cc=hch@infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=rz@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).