From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Schmitz Subject: Re: [RFC PATCH 2/2] net-next: xsurf100: drop include of lib8390.c Date: Sun, 10 Jun 2018 07:00:25 +1200 Message-ID: References: <1528523869-3403-3-git-send-email-schmitzmic@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: netdev-owner@vger.kernel.org To: Geert Uytterhoeven Cc: netdev , Linux/m68k , Andrew Lunn , Finn Thain List-Id: linux-m68k@vger.kernel.org Hi Geert, Am 10.06.2018 um 02:33 schrieb Geert Uytterhoeven: > Hi Michael, > > On Sat, Jun 9, 2018 at 7:58 AM Michael Schmitz wrote: >> >> Now that ax88796.c exports the ax_NS8390_init() symbol, we can >> include 8390.h instead of lib8390.c, avoiding duplication of that >> function and killing a few compile warnings in the bargain. >> >> Signed-off-by: Michael Schmitz > > Thanks for your patch! > > >> --- a/drivers/net/ethernet/8390/xsurf100.c >> +++ b/drivers/net/ethernet/8390/xsurf100.c >> @@ -33,8 +33,6 @@ >> #define HW_CHIPID 0x70 >> #define HW_SCRATCH 0x78 >> >> -#define __NS8390_init ax_NS8390_init >> - >> /* force unsigned long back to 'void __iomem *' */ >> #define ax_convert_addr(_a) ((void __force __iomem *)(_a)) >> >> @@ -80,12 +78,10 @@ static void reg_write16(void __iomem *base, u16 reg, u16 val) > > This doesn't apply against net-next, which doesn't have reg_write16() (yet?). Bummer - that's from my experimental ISP1173 probe code, nothing to do with network code. I'll redo these patches against net-next (and add a non-static wrapper for ax_NS8390_init to allow compiling in the driver). Thanks, Michael > Apart from that, your patch looks fine to me. > > Gr{oetje,eeting}s, > > Geert >